From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.kundenserver.de ([217.72.192.73]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k7gKP-0005sX-IQ for ptxdist@pengutronix.de; Mon, 17 Aug 2020 16:41:38 +0200 Date: Mon, 17 Aug 2020 16:41:31 +0200 From: Alexander Dahl Message-ID: <20200817144130.tdqp7tqitlqb6edj@falbala.internal.home.lespocky.de> References: <20191210100856.11655-1-christian.hermann@hytera.de> <2400094.He79FygHFi@ada> <03d6c320-ba0b-1ea3-78f5-f41a2fdc13fe@hytera.de> MIME-Version: 1.0 In-Reply-To: <03d6c320-ba0b-1ea3-78f5-f41a2fdc13fe@hytera.de> Subject: Re: [ptxdist] [PATCH] haveged: version bump 1.9.2 -> 1.9.8 List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============1042143147==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: Christian Hermann Cc: ptxdist@pengutronix.de --===============1042143147== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o2zkg2hge7s7tjp2" Content-Disposition: inline --o2zkg2hge7s7tjp2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Christian, On Mon, Aug 17, 2020 at 04:06:25PM +0200, Christian Hermann wrote: > quoting upstream > (https://raw.githubusercontent.com/jirka-h/haveged/7ae444b7a0aa64a96729d7= 8dd724b4398b9b0eaa/README.md) > ``` > The --enable-threads option is an experimental prototype for running > multiple > collection threads in a single haveged instance. The goal is to create a > multi-core haveged that would spread collection overhead more evenly > over the > available cpu resources. > ``` >=20 > I assume you read it as well and and I agree this option should be > disabled by default due to its experimental character (or at best made > configurable). Okay thanks, sufficient as explanation. I read a little more in the upstream README and also found: 286 If haveged is built with threads support, the following is present = =20 287 = =20 288 --threads , -t [] Number of threads = =20 So this is something for startup at runtime, and probably what I would want to configure at runtime. This would mean editing the init script or systemd unit and should probably done in the BSP, not in pxtdist? Greets Alex >=20 > Regards >=20 > On 13.08.20 13:55, Alexander Dahl wrote: > > Hei hei, > >=20 > > sorry for digging in mails from last year, I just stumbled over this wh= en=20 > > migrating a BSP to a newer version =E2=80=A6 > >=20 > > Am Dienstag, 10. Dezember 2019, 11:08:56 CEST schrieb Christian Hermann: > >> * upstream provides new tarballs only on github > >> * pull upstream patch to enable threads > >=20 > > What's the benefit of having threads enabled for haveged? I saw two thr= eads=20 > > running on a single core ARM SoC. Sounds quite heavy for me for such a = simple=20 > > task haveged is supposed to do? > >=20 > > Greets > > Alex > >=20 > >> * fix license identifier > >> > >> Signed-off-by: Christian Hermann > >> --- > >> ...-fix-compilation-with-enable-threads.patch | 33 +++++++++++++++++++ > >> patches/haveged-1.9.8/series | 1 + > >> rules/haveged.make | 14 ++++---- > >> 3 files changed, 42 insertions(+), 6 deletions(-) > >> create mode 100644 > >> patches/haveged-1.9.8/0001-cb1f06-fix-compilation-with-enable-threads.= patch > >> create mode 100644 patches/haveged-1.9.8/series > >> > >> diff --git > >> a/patches/haveged-1.9.8/0001-cb1f06-fix-compilation-with-enable-thread= s.pat > >> ch > >> b/patches/haveged-1.9.8/0001-cb1f06-fix-compilation-with-enable-thread= s.pat > >> ch new file mode 100644 > >> index 000000000..38895a97c > >> --- /dev/null > >> +++ > >> b/patches/haveged-1.9.8/0001-cb1f06-fix-compilation-with-enable-thread= s.pat > >> ch @@ -0,0 +1,33 @@ > >> +From cb1f0653c45d9c4a9a855119c85a1d4bfcc9b3b2 Mon Sep 17 00:00:00 2001 > >> +From: Lars Wendler > >> +Date: Thu, 14 Nov 2019 16:15:00 +0100 > >> +Subject: [PATCH] build: Fix compilation with --enable-threads > >> +MIME-Version: 1.0 > >> +Content-Type: text/plain; charset=3DUTF-8 > >> +Content-Transfer-Encoding: 8bit > >> + > >> +Previously failed with: > >> + > >> +havegetune.c:190:12: error: =E2=80=98BUILD_THREAD=E2=80=99 undeclared= (first use in this > >> function); did you mean =E2=80=98BUILD_THREADS=E2=80=99? + 190 | *= bp++ =3D BUILD_THREAD; > >> + | ^~~~~~~~~~~~ > >> + | BUILD_THREADS > >> + > >> +Signed-off-by: Lars Wendler > >> +--- > >> + src/havegetune.c | 2 +- > >> + 1 file changed, 1 insertion(+), 1 deletion(-) > >> + > >> +diff --git a/src/havegetune.c b/src/havegetune.c > >> +index de39c53..6f14476 100644 > >> +--- a/src/havegetune.c > >> ++++ b/src/havegetune.c > >> +@@ -187,7 +187,7 @@ void havege_tune( /* RETURN: none = =20 > >> */ + *bp++ =3D BUILD_CPUID; > >> + #endif > >> + #if NUMBER_CORES>1 > >> +- *bp++ =3D BUILD_THREAD; > >> ++ *bp++ =3D BUILD_THREADS; > >> + #endif > >> + #ifdef ONLINE_TESTS_ENABLE > >> + *bp++ =3D BUILD_OLT; > >> diff --git a/patches/haveged-1.9.8/series b/patches/haveged-1.9.8/seri= es > >> new file mode 100644 > >> index 000000000..cb49a0968 > >> --- /dev/null > >> +++ b/patches/haveged-1.9.8/series > >> @@ -0,0 +1 @@ > >> +0001-cb1f06-fix-compilation-with-enable-threads.patch > >> diff --git a/rules/haveged.make b/rules/haveged.make > >> index 80d1910f3..8f49ad49e 100644 > >> --- a/rules/haveged.make > >> +++ b/rules/haveged.make > >> @@ -14,16 +14,18 @@ PACKAGES-$(PTXCONF_HAVEGED) +=3D haveged > >> # > >> # Paths and names > >> # > >> -HAVEGED_VERSION :=3D 1.9.2 > >> -HAVEGED_MD5 :=3D fb1d8b3dcbb9d06b30eccd8aa500fd31 > >> +HAVEGED_VERSION :=3D 1.9.8 > >> +HAVEGED_MD5 :=3D fba3c88e416ad99ed69849b61fdcaad0 > >> HAVEGED :=3D haveged-$(HAVEGED_VERSION) > >> HAVEGED_SUFFIX :=3D tar.gz > >> HAVEGED_URL :=3D \ > >> - http://www.issihosts.com/haveged/$(HAVEGED).$(HAVEGED_SUFFIX) \ > >> - http://www.issihosts.com/haveged/archive/$(HAVEGED).$(HAVEGED_SUFFIX) > >> + https://github.com/jirka-h/haveged/archive/v$(HAVEGED_VERSION).tar.gz > >> HAVEGED_SOURCE :=3D $(SRCDIR)/$(HAVEGED).$(HAVEGED_SUFFIX) > >> HAVEGED_DIR :=3D $(BUILDDIR)/$(HAVEGED) > >> -HAVEGED_LICENSE :=3D GPL-3.0-only > >> +HAVEGED_LICENSE :=3D GPL-3.0-or-later > >> +HAVEGED_LICENSE_FILES :=3D \ > >> + file://COPYING;md5=3Dd32239bcb673463ab874e80d47fae504 \ > >> + file://src/haveged.c;startline=3D1;endline=3D19;md5=3D772ad7f0aa1fd2= 230cffdf7be7 > >> 84b15f > >> > >> # > >> ----------------------------------------------------------------------= ----- > >> - # Prepare > >> @@ -42,7 +44,7 @@ HAVEGED_CONF_OPT :=3D \ > >> --enable-initdir=3D/usr/lib/systemd/system \ > >> --disable-nistest \ > >> --disable-olt \ > >> - --disable-threads \ > >> + --enable-threads \ > >> --enable-tune > >> > >> # > >> ----------------------------------------------------------------------= ----- > >> - > >=20 > >=20 > >=20 > >=20 > >=20 > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-reque= st@pengutronix.de > >=20 pub RSA 2048/007EEC09 2020-06-24 Christian Hermann > sub RSA 2048/C750181A 2020-06-24 >=20 > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request= @pengutronix.de --=20 /"\ ASCII RIBBON | =C2=BBWith the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.=C2=AB / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie) --o2zkg2hge7s7tjp2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEwo7muQJjlc+Prwj6NK3NAHIhXMYFAl86lxoACgkQNK3NAHIh XMaiXw//TtysNlkVYN5UkaZnez9q6m5bzRS+WOtr67ULerZvR1hYTVNofzCv3IoQ RR8/K9xboBEtlV2pQ9ZoM/r8fQW+keHQqSdpuY2/VwtfCwpXNWqqo4qbg1RCMPir pRnL9vIqi9M2fXld9sRlvhrZ70GwBQQYPpmRKpBE0BerqwSeVWQrKVfVUGuN7R6W QZRt594gDN9SrBK3f4AIqcpB9ZPfSZELDBRGjjweeDPM5F+kUKk7UCr2ts8Ocgh6 VrzQziTpQZiD32utUwf8y/UWoebiAwxkZUnilR8/tiUGWYesocatsOPFRHDNvWoA YQkvJkIZKTLz9gx/vOnZNT9tQnMwn4mmOEm7bb5OM6GVFxftuYynaSLnjrt3Gc8F aFXo2Czret9pCsFg07CaPkIsx8dNn7N4N4ARwLOy30rr32ENf70/UlnevSetwXdV 6K13OFU6Kw0BWBiu3cX1+MkQTvQZTejkaHbv/TEGai9GZgy+HRR3KQ07KMA1dRum fofIB+Sumt5zEAoBknZvTtsb7yiq8chrQfhAFsjDbjYC/Y+ofR+BpoQ/cP5u2dxb pjRMZziCu6LoZtJdVqDQ5erRMsJfbmuNQ5RuKiQ5dIDaLEhduvE4Aqu57tlYfhtU KsJwrMlMk48SfncHQhTLl2cDXV7s05FH2oFV3RBQDxj0hU9+PP8= =8IS7 -----END PGP SIGNATURE----- --o2zkg2hge7s7tjp2-- --===============1042143147== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de --===============1042143147==--