mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Denis Osterland-Heim <denis.osterland@diehl.com>
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: [ptxdist] [PATCH v2] fixup! libqmi: add option to enable mbim-qmux support
Date: Fri, 14 Aug 2020 12:45:29 +0000	[thread overview]
Message-ID: <20200814124459.21932-1-Denis.Osterland@diehl.com> (raw)

Some modems require support for this in auto mode.
Default to y if ModemManager is there, beacuse it selects mbim
anyway, so the feature comes nearly no cost.
Explicit disable username option.

Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
---
Hi,

I try to understand what happens...

Regards, Denis

 rules/libqmi.in   | 13 +++++++++++--
 rules/libqmi.make |  2 ++
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/rules/libqmi.in b/rules/libqmi.in
index ac65515d3..9fe39036a 100644
--- a/rules/libqmi.in
+++ b/rules/libqmi.in
@@ -1,9 +1,18 @@
 ## SECTION=networking

-config LIBQMI
+menuconfig LIBQMI
 tristate
 select HOST_SYSTEM_PYTHON3
 select GLIB
-prompt "libqmi"
+select LIBMBIM if LIBQMI_MBIM_QMUX
+prompt "libqmi                        "
 help
   Support library to use the Qualcomm MSM Interface (QMI) protocol
+
+if LIBQMI
+
+config LIBQMI_MBIM_QMUX
+bool "enable mbim-qmux support"
+default y if MODEMMANAGER
+
+endif
diff --git a/rules/libqmi.make b/rules/libqmi.make
index 00ec44f8e..9670236e2 100644
--- a/rules/libqmi.make
+++ b/rules/libqmi.make
@@ -39,6 +39,8 @@ LIBQMI_CONF_OPT:= \
 --disable-gtk-doc \
 --disable-gtk-doc-html \
 --disable-gtk-doc-pdf \
+--disable-qmi-username \
+--$(call ptx/endis, PTXCONF_LIBQMI_MBIM_QMUX)-mbim-qmux \
 --without-udev \
 --with-udev-base-dir=/usr/lib/udev

--
2.28.0

Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/



_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

             reply	other threads:[~2020-08-14 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14 12:45 Denis Osterland-Heim [this message]
2020-08-14 13:29 ` Denis Osterland-Heim
2020-08-17  6:22   ` Michael Olbrich
2020-08-24  6:24     ` Denis Osterland-Heim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200814124459.21932-1-Denis.Osterland@diehl.com \
    --to=denis.osterland@diehl.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox