[ptxdist] [PATCH v2] libqmi: add option to enable mbim-qmux support

[ptxdist] [PATCH v2] libqmi: add option to enable mbim-qmux support

[Denis Osterland-Heim]

Some modems require support for this in auto mode.
Default to y if ModemManager is there, beacuse it selects mbim
anyway, so the feature comes nearly no cost.
Explicit disable username option.

Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
---
 rules/libqmi.in   | 13 +++++++++++--
 rules/libqmi.make |  2 ++
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/rules/libqmi.in b/rules/libqmi.in
index ac65515d3..9fe39036a 100644
--- a/rules/libqmi.in
+++ b/rules/libqmi.in
@@ -1,9 +1,18 @@
 ## SECTION=networking

-config LIBQMI
+menuconfig LIBQMI
 tristate
 select HOST_SYSTEM_PYTHON3
 select GLIB
-prompt "libqmi"
+select LIBMBIM if LIBQMI_MBIM_QMUX
+prompt "libqmi                        "
 help
   Support library to use the Qualcomm MSM Interface (QMI) protocol
+
+if LIBQMI
+
+config LIBQMI_MBIM_QMUX
+bool "enable mbim-qmux support"
+default y if MODEMMANAGER
+
+endif
diff --git a/rules/libqmi.make b/rules/libqmi.make
index 00ec44f8e..9670236e2 100644
--- a/rules/libqmi.make
+++ b/rules/libqmi.make
@@ -39,6 +39,8 @@ LIBQMI_CONF_OPT:= \
 --disable-gtk-doc \
 --disable-gtk-doc-html \
 --disable-gtk-doc-pdf \
+--disable-qmi-username \
+--$(call ptx/endis, PTXCONF_LIBQMI_MBIM_QMUX)-mbim-qmux \
 --without-udev \
 --with-udev-base-dir=/usr/lib/udev

--
2.28.0

Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/



_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH v2] libqmi: add option to enable mbim-qmux support

[Michael Olbrich]

On Thu, Aug 13, 2020 at 06:19:37AM +0000, Denis Osterland-Heim wrote:
> Some modems require support for this in auto mode.
> Default to y if ModemManager is there, beacuse it selects mbim
> anyway, so the feature comes nearly no cost.
> Explicit disable username option.
> 
> Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
> ---
>  rules/libqmi.in   | 13 +++++++++++--
>  rules/libqmi.make |  2 ++
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/libqmi.in b/rules/libqmi.in
> index ac65515d3..9fe39036a 100644
> --- a/rules/libqmi.in
> +++ b/rules/libqmi.in
> @@ -1,9 +1,18 @@
>  ## SECTION=networking
> 
> -config LIBQMI
> +menuconfig LIBQMI
>  tristate
>  select HOST_SYSTEM_PYTHON3
>  select GLIB
> -prompt "libqmi"
> +select LIBMBIM if LIBQMI_MBIM_QMUX
> +prompt "libqmi                        "

Your mail client broke the patch.

Michael

>  help
>    Support library to use the Qualcomm MSM Interface (QMI) protocol
> +
> +if LIBQMI
> +
> +config LIBQMI_MBIM_QMUX
> +bool "enable mbim-qmux support"
> +default y if MODEMMANAGER
> +
> +endif
> diff --git a/rules/libqmi.make b/rules/libqmi.make
> index 00ec44f8e..9670236e2 100644
> --- a/rules/libqmi.make
> +++ b/rules/libqmi.make
> @@ -39,6 +39,8 @@ LIBQMI_CONF_OPT:= \
>  --disable-gtk-doc \
>  --disable-gtk-doc-html \
>  --disable-gtk-doc-pdf \
> +--disable-qmi-username \
> +--$(call ptx/endis, PTXCONF_LIBQMI_MBIM_QMUX)-mbim-qmux \
>  --without-udev \
>  --with-udev-base-dir=/usr/lib/udev
> 
> --
> 2.28.0
> 
> Diehl Connectivity Solutions GmbH
> Geschäftsführung: Horst Leonberger
> Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> Nürnberg: HRB 32315
> 
> ________________________________
> 
> Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> 
> - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:
> 
> https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> 
> The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
> 
> - For general information on data protection and your respective rights please visit:
> 
> https://www.diehl.com/group/en/transparency-and-information-obligations/
> 
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de