From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2rdK-0000Bs-Rh for ptxdist@pengutronix.de; Tue, 04 Aug 2020 09:45:14 +0200 Received: from mol by dude02.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1k2rdK-0000U3-Jw for ptxdist@pengutronix.de; Tue, 04 Aug 2020 09:45:14 +0200 Date: Tue, 4 Aug 2020 09:45:14 +0200 From: Michael Olbrich Message-ID: <20200804074514.GA29132@pengutronix.de> References: <20200804071502.32351-1-Denis.Osterland@diehl.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200804071502.32351-1-Denis.Osterland@diehl.com> Subject: Re: [ptxdist] [PATCH] libqmi: add option to enable mbim-qmux support List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Tue, Aug 04, 2020 at 07:15:41AM +0000, Denis Osterland-Heim wrote: > Some modems require support for this in auto mode. > Default to y if ModemManager is there, beacuse it selects mbim > anyway, so the feature comes nearly no cost. > = > Signed-off-by: Denis Osterland-Heim > --- > rules/libqmi.in | 13 +++++++++++-- > rules/libqmi.make | 3 ++- > 2 files changed, 13 insertions(+), 3 deletions(-) > = > diff --git a/rules/libqmi.in b/rules/libqmi.in > index ac65515..9fe3903 100644 > --- a/rules/libqmi.in > +++ b/rules/libqmi.in > @@ -1,9 +1,18 @@ > ## SECTION=3Dnetworking > = > -config LIBQMI > +menuconfig LIBQMI > tristate > select HOST_SYSTEM_PYTHON3 > select GLIB > - prompt "libqmi" > + select LIBMBIM if LIBQMI_MBIM_QMUX > + prompt "libqmi " > help > Support library to use the Qualcomm MSM Interface (QMI) protocol > + > +if LIBQMI > + > +config LIBQMI_MBIM_QMUX > + bool "enable mbim-qmux support" > + default y if MODEMMANAGER > + > +endif > diff --git a/rules/libqmi.make b/rules/libqmi.make > index 00ec44f..372163c 100644 > --- a/rules/libqmi.make > +++ b/rules/libqmi.make > @@ -40,7 +40,8 @@ LIBQMI_CONF_OPT :=3D \ > --disable-gtk-doc-html \ > --disable-gtk-doc-pdf \ > --without-udev \ > - --with-udev-base-dir=3D/usr/lib/udev > + --with-udev-base-dir=3D/usr/lib/udev \ > + --$(call ptx/endis, PTXCONF_LIBQMI_MBIM_QMUX)-mbim-qmux Please use configure_helper.py to ensure that this is sorted correctly. Michael > = > # ----------------------------------------------------------------------= ------ > # Target-Install > -- = > 2.28.0 > = > = > = > Diehl Connectivity Solutions GmbH > Gesch=E4ftsf=FChrung: Horst Leonberger > Sitz der Gesellschaft: N=FCrnberg - Registergericht: Amtsgericht > N=FCrnberg: HRB 32315 > _________________________________________________________________________= __________________________ > = > Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-M= ail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. > Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhal= ten haben. Bitte loeschen Sie in diesem Fall die Nachricht. > Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung= und/oder Publikation dieser E-Mail ist strengstens untersagt. > - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten = Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflich= ten/ > = > The contents of the above mentioned e-mail is not legally binding. This e= -mail contains confidential and/or legally protected information. Please in= form us if you have received this e-mail by > mistake and delete it in such a case. Each unauthorized reproduction, dis= closure, alteration, distribution and/or publication of this e-mail is stri= ctly prohibited. = > - For general information on data protection and your respective rights p= lease visit https://www.diehl.com/group/en/transparency-and-information-obl= igations/ > = > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request= @pengutronix.de > = -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@p= engutronix.de