From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2Tyd-0002FD-1Y for ptxdist@pengutronix.de; Mon, 03 Aug 2020 08:29:39 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1k2Tyc-0007rF-PG for ptxdist@pengutronix.de; Mon, 03 Aug 2020 08:29:38 +0200 Date: Mon, 3 Aug 2020 08:29:38 +0200 From: Michael Olbrich Message-ID: <20200803062938.GJ17724@pengutronix.de> References: <20200731161141.6155-1-bruno.thomsen@gmail.com> <20200731161141.6155-7-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200731161141.6155-7-bruno.thomsen@gmail.com> Subject: Re: [ptxdist] [PATCH v3 7/7] chrony: make unrecognized configure options fatal List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Jul 31, 2020 at 06:11:41PM +0200, Bruno Thomsen wrote: > Add a little help for package maintainers to highlight > possible future issues. > > Signed-off-by: Bruno Thomsen > --- > New in version 3: > - package patch: make the 'Unrecognized option' a fatal configure error. > - Michael feel free to drop this if I misunderstood how to do it :) This is exactly what I meant. Thank you. Michael > ...ke-unrecognized-option-a-fatal-error.patch | 25 +++++++++++++++++++ > patches/chrony-3.5/series | 4 +++ > 2 files changed, 29 insertions(+) > create mode 100644 patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch > create mode 100644 patches/chrony-3.5/series > > diff --git a/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch b/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch > new file mode 100644 > index 000000000..01f213633 > --- /dev/null > +++ b/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch > @@ -0,0 +1,25 @@ > +From: Bruno Thomsen > +Date: Fri, 31 Jul 2020 09:07:49 +0000 > +Subject: [PATCH] configure: make unrecognized option a fatal error > + > +This helps catch cases where options has been removed > +and are no longer valid. Including additional cross-build > +options that cannot be used. > + > +Signed-off-by: Bruno Thomsen > +--- > + configure | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/configure b/configure > +index 323f5743cd57..080f7bce746d 100755 > +--- a/configure > ++++ b/configure > +@@ -388,6 +388,7 @@ do > + ;; > + * ) > + echo "Unrecognized option : " $option > ++ exit 1 > + esac > + done > + > diff --git a/patches/chrony-3.5/series b/patches/chrony-3.5/series > new file mode 100644 > index 000000000..501972558 > --- /dev/null > +++ b/patches/chrony-3.5/series > @@ -0,0 +1,4 @@ > +# generated by git-ptx-patches > +#tag:base --start-number 1 > +0001-configure-make-unrecognized-option-a-fatal-error.patch > +# c182e03aeda3f8c148ae51d52f839a6a - git-ptx-patches magic > -- > 2.26.2 > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de