Re: [ptxdist] [PATCH v3 7/7] chrony: make unrecognized configure options fatal

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jul 31, 2020 at 06:11:41PM +0200, Bruno Thomsen wrote:
> Add a little help for package maintainers to highlight
> possible future issues.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> New in version 3:
> - package patch: make the 'Unrecognized option' a fatal configure error.
> - Michael feel free to drop this if I misunderstood how to do it :)

This is exactly what I meant. Thank you.

Michael

>  ...ke-unrecognized-option-a-fatal-error.patch | 25 +++++++++++++++++++
>  patches/chrony-3.5/series                     |  4 +++
>  2 files changed, 29 insertions(+)
>  create mode 100644 patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
>  create mode 100644 patches/chrony-3.5/series
> 
> diff --git a/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch b/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
> new file mode 100644
> index 000000000..01f213633
> --- /dev/null
> +++ b/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
> @@ -0,0 +1,25 @@
> +From: Bruno Thomsen <bruno.thomsen@gmail.com>
> +Date: Fri, 31 Jul 2020 09:07:49 +0000
> +Subject: [PATCH] configure: make unrecognized option a fatal error
> +
> +This helps catch cases where options has been removed
> +and are no longer valid. Including additional cross-build
> +options that cannot be used.
> +
> +Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> +---
> + configure | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/configure b/configure
> +index 323f5743cd57..080f7bce746d 100755
> +--- a/configure
> ++++ b/configure
> +@@ -388,6 +388,7 @@ do
> +     ;;
> +     * )
> +     echo "Unrecognized option : " $option
> ++    exit 1
> +     esac
> + done
> + 
> diff --git a/patches/chrony-3.5/series b/patches/chrony-3.5/series
> new file mode 100644
> index 000000000..501972558
> --- /dev/null
> +++ b/patches/chrony-3.5/series
> @@ -0,0 +1,4 @@
> +# generated by git-ptx-patches
> +#tag:base --start-number 1
> +0001-configure-make-unrecognized-option-a-fatal-error.patch
> +# c182e03aeda3f8c148ae51d52f839a6a  - git-ptx-patches magic
> -- 
> 2.26.2
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de