mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>, bth@kamstrup.com
Subject: [ptxdist] [PATCH v3 7/7] chrony: make unrecognized configure options fatal
Date: Fri, 31 Jul 2020 18:11:41 +0200	[thread overview]
Message-ID: <20200731161141.6155-7-bruno.thomsen@gmail.com> (raw)
In-Reply-To: <20200731161141.6155-1-bruno.thomsen@gmail.com>

Add a little help for package maintainers to highlight
possible future issues.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
New in version 3:
- package patch: make the 'Unrecognized option' a fatal configure error.
- Michael feel free to drop this if I misunderstood how to do it :)

 ...ke-unrecognized-option-a-fatal-error.patch | 25 +++++++++++++++++++
 patches/chrony-3.5/series                     |  4 +++
 2 files changed, 29 insertions(+)
 create mode 100644 patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
 create mode 100644 patches/chrony-3.5/series

diff --git a/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch b/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
new file mode 100644
index 000000000..01f213633
--- /dev/null
+++ b/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
@@ -0,0 +1,25 @@
+From: Bruno Thomsen <bruno.thomsen@gmail.com>
+Date: Fri, 31 Jul 2020 09:07:49 +0000
+Subject: [PATCH] configure: make unrecognized option a fatal error
+
+This helps catch cases where options has been removed
+and are no longer valid. Including additional cross-build
+options that cannot be used.
+
+Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
+---
+ configure | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/configure b/configure
+index 323f5743cd57..080f7bce746d 100755
+--- a/configure
++++ b/configure
+@@ -388,6 +388,7 @@ do
+     ;;
+     * )
+     echo "Unrecognized option : " $option
++    exit 1
+     esac
+ done
+ 
diff --git a/patches/chrony-3.5/series b/patches/chrony-3.5/series
new file mode 100644
index 000000000..501972558
--- /dev/null
+++ b/patches/chrony-3.5/series
@@ -0,0 +1,4 @@
+# generated by git-ptx-patches
+#tag:base --start-number 1
+0001-configure-make-unrecognized-option-a-fatal-error.patch
+# c182e03aeda3f8c148ae51d52f839a6a  - git-ptx-patches magic
-- 
2.26.2

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  parent reply	other threads:[~2020-07-31 16:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 16:11 [ptxdist] [PATCH v3 1/7] chrony: version bump 3.3 -> 3.5 Bruno Thomsen
2020-07-31 16:11 ` [ptxdist] [PATCH v3 2/7] chrony: nettle authentication support Bruno Thomsen
2020-08-03  6:30   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-31 16:11 ` [ptxdist] [PATCH v3 3/7] chrony: systemd unit option Bruno Thomsen
2020-08-03  6:30   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-31 16:11 ` [ptxdist] [PATCH v3 4/7] passwd/group: added chrony UID/GID Bruno Thomsen
2020-08-03  6:30   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-31 16:11 ` [ptxdist] [PATCH v3 5/7] chrony: run chronyd as chrony user Bruno Thomsen
2020-08-03  6:30   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-31 16:11 ` [ptxdist] [PATCH v3 6/7] chrony: advanced monitoring command option Bruno Thomsen
2020-08-03  6:30   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-31 16:11 ` Bruno Thomsen [this message]
2020-08-03  6:29   ` [ptxdist] [PATCH v3 7/7] chrony: make unrecognized configure options fatal Michael Olbrich
2020-08-03  6:30   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-08-03  6:30 ` [ptxdist] [APPLIED] chrony: version bump 3.3 -> 3.5 Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200731161141.6155-7-bruno.thomsen@gmail.com \
    --to=bruno.thomsen@gmail.com \
    --cc=bth@kamstrup.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox