Re: [ptxdist] [PATCH v2 1/6] chrony: version bump 3.3 -> 3.5

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jul 29, 2020 at 09:29:23PM +0200, Bruno Thomsen wrote:
> Always enable ntp support as it does not require
> extra dependencies.
> 
> Updated project URL in package help as sunsite.dk has
> been renamed to dotsrc.org and have shutdown the general
> project hosting part.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> Changes since version 1:
> - Fix typo in subject line.
> - Updated URL in package help text.
> - Explicit enable ntp option.
>   This outputs unrecognized option, but we still get expected result.
>   Unrecognized option :  --enable-ntp

Please go back to the version and remove the options.
In this case I'd like to notice it if options become invalid after an
update. Even if I need to look at the configure output.

The same for the other patches.

And can you add a comment, that this is not autoconf, above the configure
options? This makes it clear why ptx/endis etc. is not used.

Bonus points if you replace the CROSS_AUTOCONF_USR with the actually
supported options and add a patch to make the 'Unrecognized option' a fatal
error. But I'll accept the patches without this part.

Michael

> 
>  rules/chrony.in   | 2 +-
>  rules/chrony.make | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/rules/chrony.in b/rules/chrony.in
> index ccdcb71d0..1f5e241c9 100644
> --- a/rules/chrony.in
> +++ b/rules/chrony.in
> @@ -17,7 +17,7 @@ menuconfig CHRONY
>  	  to chronyd for monitoring its performance and configuring
>  	  various settings.
>  
> -	  See http://chrony.sunsite.dk/ for details
> +	  See https://chrony.tuxfamily.org/ for details.
>  
>  if CHRONY
>  
> diff --git a/rules/chrony.make b/rules/chrony.make
> index 61fe4a7fd..06fc7fd9a 100644
> --- a/rules/chrony.make
> +++ b/rules/chrony.make
> @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_CHRONY) += chrony
>  #
>  # Paths and names
>  #
> -CHRONY_VERSION	:= 3.3
> -CHRONY_MD5	:= 81ab62cf5d60b4b3fa8cd2c1b267ffd9
> +CHRONY_VERSION	:= 3.5
> +CHRONY_MD5	:= 5f66338bc940a9b51eede8f391e7bed3
>  CHRONY		:= chrony-$(CHRONY_VERSION)
>  CHRONY_SUFFIX	:= tar.gz
>  CHRONY_URL	:= http://download.tuxfamily.org/chrony/$(CHRONY).$(CHRONY_SUFFIX)
> @@ -44,7 +44,7 @@ CHRONY_CONF_OPT		:= \
>  	--without-nss \
>  	--without-tomcrypt \
>  	--disable-cmdmon \
> -	--disable-ntp \
> +	--enable-ntp \
>  	--disable-refclock \
>  	--disable-phc \
>  	--disable-pps \
> 
> base-commit: 6721ecdd3deb6e5839462086e9526d6f6c744cea
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de