mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 5/6] chrony: run as chrony user option
Date: Thu, 30 Jul 2020 11:58:29 +0200	[thread overview]
Message-ID: <20200730095829.GF30568@pengutronix.de> (raw)
In-Reply-To: <20200724154843.5552-5-bruno.thomsen@gmail.com>

On Fri, Jul 24, 2020 at 05:48:42PM +0200, Bruno Thomsen wrote:
> Default chrony service run as root and that is not
> best practice as it's doing network communication.

Is there a use-case to run chrony as root? I think we can skip the option
and always run it as user chrony.

Michael

> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
>  rules/chrony.in   | 7 +++++++
>  rules/chrony.make | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/rules/chrony.in b/rules/chrony.in
> index 525be2681..6a4f12de0 100644
> --- a/rules/chrony.in
> +++ b/rules/chrony.in
> @@ -29,6 +29,13 @@ config CHRONY_USE_NETTLE
>  	  Use nettle crypto library for stronger keys than MD5 in
>  	  NTP authentication.
>  
> +config CHRONY_RUN_AS_NON_ROOT
> +	bool
> +	prompt "Run chronyd as non root user"
> +	help
> +	  Default chronyd is started as root, select this
> +	  to run service with chrony user.
> +
>  comment "install options   ---"
>  
>  config CHRONY_INSTALL_CHRONY_COMMAND
> diff --git a/rules/chrony.make b/rules/chrony.make
> index a72752030..d5ae52883 100644
> --- a/rules/chrony.make
> +++ b/rules/chrony.make
> @@ -48,6 +48,7 @@ CHRONY_CONF_OPT		:= \
>  	--disable-phc \
>  	--disable-pps \
>  	$(call ptx/ifdef, PTXCONF_GLOBAL_IPV6,,--disable-ipv6) \
> +	$(call ptx/ifdef, PTXCONF_CHRONY_RUN_AS_USER,--with-user=chrony,) \
>  	--without-seccomp
>  
>  # ----------------------------------------------------------------------------
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2020-07-30  9:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 15:48 [ptxdist] [PATCH 1/6] chrony: verion bump 3.3 -> 3.5 Bruno Thomsen
2020-07-24 15:48 ` [ptxdist] [PATCH 2/6] chrony: nettle authentication support Bruno Thomsen
2020-07-24 15:48 ` [ptxdist] [PATCH 3/6] chrony: systemd unit option Bruno Thomsen
2020-07-27  6:19   ` Bruno Thomsen
2020-07-27  9:17     ` Roland Hieber
2020-07-30  9:52       ` Michael Olbrich
2020-07-24 15:48 ` [ptxdist] [PATCH 4/6] passwd/group: added chrony UID/GID Bruno Thomsen
2020-07-30  9:55   ` Michael Olbrich
2020-07-24 15:48 ` [ptxdist] [PATCH 5/6] chrony: run as chrony user option Bruno Thomsen
2020-07-30  9:58   ` Michael Olbrich [this message]
2020-07-24 15:48 ` [ptxdist] [PATCH 6/6] chrony: advanced command monitoring option Bruno Thomsen
2020-07-27  9:22   ` Roland Hieber
2020-07-30  9:53     ` Michael Olbrich
2020-07-27  9:12 ` [ptxdist] [PATCH 1/6] chrony: verion bump 3.3 -> 3.5 Roland Hieber
2020-07-30  9:51   ` Michael Olbrich
2020-07-27  9:13 ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730095829.GF30568@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox