From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>, bth@kamstrup.com
Subject: Re: [ptxdist] [PATCH 6/6] chrony: advanced command monitoring option
Date: Thu, 30 Jul 2020 11:53:36 +0200 [thread overview]
Message-ID: <20200730095336.GD30568@pengutronix.de> (raw)
In-Reply-To: <20200727092200.oizlqcehorrzc3ra@pengutronix.de>
On Mon, Jul 27, 2020 at 11:22:00AM +0200, Roland Hieber wrote:
> On Fri, Jul 24, 2020 at 05:48:43PM +0200, Bruno Thomsen wrote:
> > When you need to dig deep into NTP sync status.
> >
> > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > ---
> > rules/chrony.in | 7 +++++++
> > rules/chrony.make | 3 ++-
> > 2 files changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/rules/chrony.in b/rules/chrony.in
> > index 6a4f12de0..ad9baa2bf 100644
> > --- a/rules/chrony.in
> > +++ b/rules/chrony.in
> > @@ -36,6 +36,13 @@ config CHRONY_RUN_AS_NON_ROOT
> > Default chronyd is started as root, select this
> > to run service with chrony user.
> >
> > +config CHRONY_ADVANCED_COMMAND
> > + bool
> > + prompt "Enable advanced command monitoring"
> > + help
> > + This allow getting advanced NTP sync status
> > + monitoring from the service.
> > +
> > comment "install options ---"
> >
> > config CHRONY_INSTALL_CHRONY_COMMAND
> > diff --git a/rules/chrony.make b/rules/chrony.make
> > index d5ae52883..3d8b64b35 100644
> > --- a/rules/chrony.make
> > +++ b/rules/chrony.make
> > @@ -43,7 +43,8 @@ CHRONY_CONF_OPT := \
> > $(call ptx/ifdef, PTXCONF_CHRONY_USE_NETTLE,,--without-nettle) \
> > --without-nss \
> > --without-tomcrypt \
> > - --disable-cmdmon \
> > + $(call ptx/ifdef, CHRONY_ADVANCED_COMMAND,,--disable-cmdmon) \
> > + $(call ptx/ifdef, CHRONY_ADVANCED_COMMAND,--enable-debug,) \
>
> Here too – reproducible config options are important. Use
>
> --$(call ptx/endis, CHRONY_ADVANCED_COMMAND)-cmdmon \
> --$(call ptx/endis, CHRONY_ADVANCED_COMMAND)-debug \
>
> instead (unless the configure option is broken…).
Not autoconf and very broken. The patch is correct.
Michael
> - Roland
>
> > --disable-refclock \
> > --disable-phc \
> > --disable-pps \
> > --
> > 2.26.2
> >
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> >
>
> --
> Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
> Steuerwalder Str. 21 | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-07-30 9:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 15:48 [ptxdist] [PATCH 1/6] chrony: verion bump 3.3 -> 3.5 Bruno Thomsen
2020-07-24 15:48 ` [ptxdist] [PATCH 2/6] chrony: nettle authentication support Bruno Thomsen
2020-07-24 15:48 ` [ptxdist] [PATCH 3/6] chrony: systemd unit option Bruno Thomsen
2020-07-27 6:19 ` Bruno Thomsen
2020-07-27 9:17 ` Roland Hieber
2020-07-30 9:52 ` Michael Olbrich
2020-07-24 15:48 ` [ptxdist] [PATCH 4/6] passwd/group: added chrony UID/GID Bruno Thomsen
2020-07-30 9:55 ` Michael Olbrich
2020-07-24 15:48 ` [ptxdist] [PATCH 5/6] chrony: run as chrony user option Bruno Thomsen
2020-07-30 9:58 ` Michael Olbrich
2020-07-24 15:48 ` [ptxdist] [PATCH 6/6] chrony: advanced command monitoring option Bruno Thomsen
2020-07-27 9:22 ` Roland Hieber
2020-07-30 9:53 ` Michael Olbrich [this message]
2020-07-27 9:12 ` [ptxdist] [PATCH 1/6] chrony: verion bump 3.3 -> 3.5 Roland Hieber
2020-07-30 9:51 ` Michael Olbrich
2020-07-27 9:13 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730095336.GD30568@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=bruno.thomsen@gmail.com \
--cc=bth@kamstrup.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox