From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k15Ef-0000BL-BT for ptxdist@pengutronix.de; Thu, 30 Jul 2020 11:52:25 +0200 Received: from mol by dude02.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1k15Ef-0000wS-38 for ptxdist@pengutronix.de; Thu, 30 Jul 2020 11:52:25 +0200 Date: Thu, 30 Jul 2020 11:52:25 +0200 From: Michael Olbrich Message-ID: <20200730095225.GC30568@pengutronix.de> References: <20200724154843.5552-1-bruno.thomsen@gmail.com> <20200724154843.5552-3-bruno.thomsen@gmail.com> <20200727091744.j2urkxr5jogluqcr@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200727091744.j2urkxr5jogluqcr@pengutronix.de> Subject: Re: [ptxdist] [PATCH 3/6] chrony: systemd unit option List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Mon, Jul 27, 2020 at 11:17:44AM +0200, Roland Hieber wrote: > On Mon, Jul 27, 2020 at 08:19:08AM +0200, Bruno Thomsen wrote: > > Den fre. 24. jul. 2020 kl. 17.48 skrev Bruno Thomsen : > > > > > > Signed-off-by: Bruno Thomsen > > > --- > > > rules/chrony.in | 7 +++++++ > > > rules/chrony.make | 8 ++++++++ > > > 2 files changed, 15 insertions(+) > > > > > +ifdef PTXCONF_CHRONY_SYSTEMD_UNIT > > > + @$(call install_alternative, chrony, 0, 0, 0644, \ > > > + $(CHRONY_DIR)/examples/chronyd.service, /usr/lib/systemd/system/chronyd.service) > > > > This should have been an install_copy. > > No, install_alternative is better, so users can adjust it via > projectroot/. It will take the file from the package's install dir > automatically if nothing is found in projectroot/ [1]. If you have no > way of getting the package to install its service file, just copy the > default version into projectroot/ so install_alternative can find it. In this case, you should install $(CHRONY_DIR)/examples/chronyd.service to $(CHRONY_PKGDIR)/usr/lib/systemd/system/chronyd.service in the install stage. And then use install_alternative. Michael > [1]: https://www.ptxdist.org/doc/ref_make_macros.html#install-alternative > > - Roland > > > > > /Bruno > > > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > > > > -- > Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | > Steuerwalder Str. 21 | https://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de