From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 3/6] chrony: systemd unit option
Date: Thu, 30 Jul 2020 11:52:25 +0200 [thread overview]
Message-ID: <20200730095225.GC30568@pengutronix.de> (raw)
In-Reply-To: <20200727091744.j2urkxr5jogluqcr@pengutronix.de>
On Mon, Jul 27, 2020 at 11:17:44AM +0200, Roland Hieber wrote:
> On Mon, Jul 27, 2020 at 08:19:08AM +0200, Bruno Thomsen wrote:
> > Den fre. 24. jul. 2020 kl. 17.48 skrev Bruno Thomsen <bruno.thomsen@gmail.com>:
> > >
> > > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > > ---
> > > rules/chrony.in | 7 +++++++
> > > rules/chrony.make | 8 ++++++++
> > > 2 files changed, 15 insertions(+)
> >
> > > +ifdef PTXCONF_CHRONY_SYSTEMD_UNIT
> > > + @$(call install_alternative, chrony, 0, 0, 0644, \
> > > + $(CHRONY_DIR)/examples/chronyd.service, /usr/lib/systemd/system/chronyd.service)
> >
> > This should have been an install_copy.
>
> No, install_alternative is better, so users can adjust it via
> projectroot/. It will take the file from the package's install dir
> automatically if nothing is found in projectroot/ [1]. If you have no
> way of getting the package to install its service file, just copy the
> default version into projectroot/ so install_alternative can find it.
In this case, you should install $(CHRONY_DIR)/examples/chronyd.service to
$(CHRONY_PKGDIR)/usr/lib/systemd/system/chronyd.service in the install
stage. And then use install_alternative.
Michael
> [1]: https://www.ptxdist.org/doc/ref_make_macros.html#install-alternative
>
> - Roland
>
> >
> > /Bruno
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> >
>
> --
> Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
> Steuerwalder Str. 21 | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-07-30 9:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 15:48 [ptxdist] [PATCH 1/6] chrony: verion bump 3.3 -> 3.5 Bruno Thomsen
2020-07-24 15:48 ` [ptxdist] [PATCH 2/6] chrony: nettle authentication support Bruno Thomsen
2020-07-24 15:48 ` [ptxdist] [PATCH 3/6] chrony: systemd unit option Bruno Thomsen
2020-07-27 6:19 ` Bruno Thomsen
2020-07-27 9:17 ` Roland Hieber
2020-07-30 9:52 ` Michael Olbrich [this message]
2020-07-24 15:48 ` [ptxdist] [PATCH 4/6] passwd/group: added chrony UID/GID Bruno Thomsen
2020-07-30 9:55 ` Michael Olbrich
2020-07-24 15:48 ` [ptxdist] [PATCH 5/6] chrony: run as chrony user option Bruno Thomsen
2020-07-30 9:58 ` Michael Olbrich
2020-07-24 15:48 ` [ptxdist] [PATCH 6/6] chrony: advanced command monitoring option Bruno Thomsen
2020-07-27 9:22 ` Roland Hieber
2020-07-30 9:53 ` Michael Olbrich
2020-07-27 9:12 ` [ptxdist] [PATCH 1/6] chrony: verion bump 3.3 -> 3.5 Roland Hieber
2020-07-30 9:51 ` Michael Olbrich
2020-07-27 9:13 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730095225.GC30568@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox