mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH 1/2] nss: bring headers in order
@ 2020-07-24 13:02 Roland Hieber
  2020-07-24 13:02 ` [ptxdist] [PATCH 2/2] nss: don't build in parallel Roland Hieber
  2020-08-04  7:23 ` [ptxdist] [APPLIED] nss: bring headers in order Michael Olbrich
  0 siblings, 2 replies; 6+ messages in thread
From: Roland Hieber @ 2020-07-24 13:02 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Apparently the header for the compile stage variables got lost.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/nss.make | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/rules/nss.make b/rules/nss.make
index e71837e8e3a4..9364755f63c9 100644
--- a/rules/nss.make
+++ b/rules/nss.make
@@ -25,12 +25,17 @@ NSS_SUBDIR	:= nss
 NSS_LICENSE	:= MPL-2.0
 NSS_LICENSE_FILES	:= \
 	file://$(NSS_SUBDIR)/COPYING;md5=3b1e88e1b9c0b5a4b2881d46cce06a18
+
 # ----------------------------------------------------------------------------
 # Prepare
 # ----------------------------------------------------------------------------
 
 NSS_CONF_TOOL	:= NO
 
+# ----------------------------------------------------------------------------
+# Compile
+# ----------------------------------------------------------------------------
+
 NSS_ARCH := $(call remove_quotes,$(PTXCONF_ARCH_STRING))
 ifdef PTXCONF_ARCH_ARM64
 NSS_ARCH := aarch64
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ptxdist] [PATCH 2/2] nss: don't build in parallel
  2020-07-24 13:02 [ptxdist] [PATCH 1/2] nss: bring headers in order Roland Hieber
@ 2020-07-24 13:02 ` Roland Hieber
  2020-07-24 14:31   ` Michael Olbrich
  2020-08-04  7:23 ` [ptxdist] [APPLIED] nss: bring headers in order Michael Olbrich
  1 sibling, 1 reply; 6+ messages in thread
From: Roland Hieber @ 2020-07-24 13:02 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

NSS has a custom-made build system, but on some systems, building in
parallel can lead to strange compile failures, like:

  ../../../coreconf/nsinstall/Linux5.1.21_arm_glibc_PTH_OPT.OBJ/nsinstall -R -m 444 nssckbi.h ../../../../dist/public/nss
  symlink creation race: /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/dist/public/nss/nssckbi.h
  nsinstall: symlink was attempted in working directory /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/nss/lib/ckfw/builtins from ../../../nss/lib/ckfw/builtins/nssckbi.h to /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/dist/public/nss/nssckbi.h.
  : File exists
  make[5]: *** [../../../coreconf/rules.mk:387: ../../../../dist/public/nss/nssckbi.h] Aborted (core dumped)

Disable parallel building for now, which seems to solve the problem.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/nss.make | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/rules/nss.make b/rules/nss.make
index 9364755f63c9..d3abe8a0b166 100644
--- a/rules/nss.make
+++ b/rules/nss.make
@@ -44,6 +44,8 @@ ifeq ($(NSS_ARCH),i386)
 NSS_ARCH := x86
 endif
 
+NSS_MAKE_PAR := NO
+
 NSS_MAKE_ENV := \
 	$(CROSS_ENV) \
 	CCC=$(CROSS_CXX) \
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ptxdist] [PATCH 2/2] nss: don't build in parallel
  2020-07-24 13:02 ` [ptxdist] [PATCH 2/2] nss: don't build in parallel Roland Hieber
@ 2020-07-24 14:31   ` Michael Olbrich
  2020-07-27  8:48     ` Roland Hieber
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Olbrich @ 2020-07-24 14:31 UTC (permalink / raw)
  To: ptxdist

On Fri, Jul 24, 2020 at 03:02:38PM +0200, Roland Hieber wrote:
> NSS has a custom-made build system, but on some systems, building in
> parallel can lead to strange compile failures, like:
> 
>   ../../../coreconf/nsinstall/Linux5.1.21_arm_glibc_PTH_OPT.OBJ/nsinstall -R -m 444 nssckbi.h ../../../../dist/public/nss
>   symlink creation race: /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/dist/public/nss/nssckbi.h
>   nsinstall: symlink was attempted in working directory /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/nss/lib/ckfw/builtins from ../../../nss/lib/ckfw/builtins/nssckbi.h to /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/dist/public/nss/nssckbi.h.
>   : File exists
>   make[5]: *** [../../../coreconf/rules.mk:387: ../../../../dist/public/nss/nssckbi.h] Aborted (core dumped)
> 
> Disable parallel building for now, which seems to solve the problem.

Did you test this with the latest nss patches from master? I'm pretty sure
I fixed this issue there.

Michael

> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/nss.make | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/rules/nss.make b/rules/nss.make
> index 9364755f63c9..d3abe8a0b166 100644
> --- a/rules/nss.make
> +++ b/rules/nss.make
> @@ -44,6 +44,8 @@ ifeq ($(NSS_ARCH),i386)
>  NSS_ARCH := x86
>  endif
>  
> +NSS_MAKE_PAR := NO
> +
>  NSS_MAKE_ENV := \
>  	$(CROSS_ENV) \
>  	CCC=$(CROSS_CXX) \
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ptxdist] [PATCH 2/2] nss: don't build in parallel
  2020-07-24 14:31   ` Michael Olbrich
@ 2020-07-27  8:48     ` Roland Hieber
  2020-08-03 14:11       ` Roland Hieber
  0 siblings, 1 reply; 6+ messages in thread
From: Roland Hieber @ 2020-07-27  8:48 UTC (permalink / raw)
  To: ptxdist

On Fri, Jul 24, 2020 at 04:31:01PM +0200, Michael Olbrich wrote:
> On Fri, Jul 24, 2020 at 03:02:38PM +0200, Roland Hieber wrote:
> > NSS has a custom-made build system, but on some systems, building in
> > parallel can lead to strange compile failures, like:
> > 
> >   ../../../coreconf/nsinstall/Linux5.1.21_arm_glibc_PTH_OPT.OBJ/nsinstall -R -m 444 nssckbi.h ../../../../dist/public/nss
> >   symlink creation race: /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/dist/public/nss/nssckbi.h
> >   nsinstall: symlink was attempted in working directory /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/nss/lib/ckfw/builtins from ../../../nss/lib/ckfw/builtins/nssckbi.h to /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/dist/public/nss/nssckbi.h.
> >   : File exists
> >   make[5]: *** [../../../coreconf/rules.mk:387: ../../../../dist/public/nss/nssckbi.h] Aborted (core dumped)
> > 
> > Disable parallel building for now, which seems to solve the problem.
> 
> Did you test this with the latest nss patches from master? I'm pretty sure
> I fixed this issue there.

Ah no, I overlooked these! I'll try them first.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ptxdist] [PATCH 2/2] nss: don't build in parallel
  2020-07-27  8:48     ` Roland Hieber
@ 2020-08-03 14:11       ` Roland Hieber
  0 siblings, 0 replies; 6+ messages in thread
From: Roland Hieber @ 2020-08-03 14:11 UTC (permalink / raw)
  To: ptxdist

On Mon, Jul 27, 2020 at 10:48:15AM +0200, Roland Hieber wrote:
> On Fri, Jul 24, 2020 at 04:31:01PM +0200, Michael Olbrich wrote:
> > On Fri, Jul 24, 2020 at 03:02:38PM +0200, Roland Hieber wrote:
> > > NSS has a custom-made build system, but on some systems, building in
> > > parallel can lead to strange compile failures, like:
> > > 
> > >   ../../../coreconf/nsinstall/Linux5.1.21_arm_glibc_PTH_OPT.OBJ/nsinstall -R -m 444 nssckbi.h ../../../../dist/public/nss
> > >   symlink creation race: /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/dist/public/nss/nssckbi.h
> > >   nsinstall: symlink was attempted in working directory /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/nss/lib/ckfw/builtins from ../../../nss/lib/ckfw/builtins/nssckbi.h to /srv/jenkins-data/.../platform-nnn/build-target/nss-3.54/dist/public/nss/nssckbi.h.
> > >   : File exists
> > >   make[5]: *** [../../../coreconf/rules.mk:387: ../../../../dist/public/nss/nssckbi.h] Aborted (core dumped)
> > > 
> > > Disable parallel building for now, which seems to solve the problem.
> > 
> > Did you test this with the latest nss patches from master? I'm pretty sure
> > I fixed this issue there.
> 
> Ah no, I overlooked these! I'll try them first.

For the record, the patches did the thing.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ptxdist] [APPLIED] nss: bring headers in order
  2020-07-24 13:02 [ptxdist] [PATCH 1/2] nss: bring headers in order Roland Hieber
  2020-07-24 13:02 ` [ptxdist] [PATCH 2/2] nss: don't build in parallel Roland Hieber
@ 2020-08-04  7:23 ` Michael Olbrich
  1 sibling, 0 replies; 6+ messages in thread
From: Michael Olbrich @ 2020-08-04  7:23 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Thanks, applied as 87d5b18589a45ab3c82041b5d8f2015b7eb0aa5c.

Michael

[sent from post-receive hook]

On Tue, 04 Aug 2020 09:23:25 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> Apparently the header for the compile stage variables got lost.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200724130238.6287-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/nss.make b/rules/nss.make
> index e71837e8e3a4..9364755f63c9 100644
> --- a/rules/nss.make
> +++ b/rules/nss.make
> @@ -25,12 +25,17 @@ NSS_SUBDIR	:= nss
>  NSS_LICENSE	:= MPL-2.0
>  NSS_LICENSE_FILES	:= \
>  	file://$(NSS_SUBDIR)/COPYING;md5=3b1e88e1b9c0b5a4b2881d46cce06a18
> +
>  # ----------------------------------------------------------------------------
>  # Prepare
>  # ----------------------------------------------------------------------------
>  
>  NSS_CONF_TOOL	:= NO
>  
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
>  NSS_ARCH := $(call remove_quotes,$(PTXCONF_ARCH_STRING))
>  ifdef PTXCONF_ARCH_ARM64
>  NSS_ARCH := aarch64

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-08-04  7:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-24 13:02 [ptxdist] [PATCH 1/2] nss: bring headers in order Roland Hieber
2020-07-24 13:02 ` [ptxdist] [PATCH 2/2] nss: don't build in parallel Roland Hieber
2020-07-24 14:31   ` Michael Olbrich
2020-07-27  8:48     ` Roland Hieber
2020-08-03 14:11       ` Roland Hieber
2020-08-04  7:23 ` [ptxdist] [APPLIED] nss: bring headers in order Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox