From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>, bth@kamstrup.com
Subject: [ptxdist] [PATCH v3 4/5] host-squashfs-tools: conditional select lzo and xz dependencies
Date: Fri, 24 Jul 2020 17:51:02 +0200 [thread overview]
Message-ID: <20200724155103.6374-4-bruno.thomsen@gmail.com> (raw)
In-Reply-To: <20200724155103.6374-1-bruno.thomsen@gmail.com>
Only select host lzo and host xz packages when needed to
speed up complete build time and avoid unnecessary dependencies.
Update image-root-squashfs Kconfig dependency selection.
Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
Changes since version 2:
Select HOST_SQUASHFS_TOOLS_LZO_SUPPORT config.
Select HOST_SQUASHFS_TOOLS_XZ_SUPPORT config.
Added HOST_SQUASHFS_TOOLS_LZO_SUPPORT config.
Added HOST_SQUASHFS_TOOLS_XZ_SUPPORT config.
No changes since version 1.
platforms/image-root-squashfs.in | 2 ++
rules/host-squashfs-tools.in | 10 ++++++++--
rules/host-squashfs-tools.make | 4 ++--
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/platforms/image-root-squashfs.in b/platforms/image-root-squashfs.in
index 98aae9c1c..a6d1d1b44 100644
--- a/platforms/image-root-squashfs.in
+++ b/platforms/image-root-squashfs.in
@@ -4,6 +4,8 @@ menuconfig IMAGE_ROOT_SQUASHFS
tristate
select HOST_GENIMAGE
select HOST_SQUASHFS_TOOLS
+ select HOST_SQUASHFS_TOOLS_LZO_SUPPORT if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_LZO
+ select HOST_SQUASHFS_TOOLS_XZ_SUPPORT if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_XZ
select HOST_SQUASHFS_TOOLS_ZSTD_SUPPORT if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
select IMAGE_ROOT_TGZ
prompt "Generate images/root.squashfs "
diff --git a/rules/host-squashfs-tools.in b/rules/host-squashfs-tools.in
index 04de7d1fc..3ba693aaf 100644
--- a/rules/host-squashfs-tools.in
+++ b/rules/host-squashfs-tools.in
@@ -3,13 +3,19 @@
config HOST_SQUASHFS_TOOLS
tristate
select HOST_ZLIB
- select HOST_LIBLZO
- select HOST_XZ
+ select HOST_LIBLZO if HOST_SQUASHFS_TOOLS_LZO_SUPPORT
+ select HOST_XZ if HOST_SQUASHFS_TOOLS_XZ_SUPPORT
select HOST_ZSTD if HOST_SQUASHFS_TOOLS_ZSTD_SUPPORT
default y if ALLYES
if HOST_SQUASHFS_TOOLS
+config HOST_SQUASHFS_TOOLS_LZO_SUPPORT
+ bool
+
+config HOST_SQUASHFS_TOOLS_XZ_SUPPORT
+ bool
+
config HOST_SQUASHFS_TOOLS_ZSTD_SUPPORT
bool
diff --git a/rules/host-squashfs-tools.make b/rules/host-squashfs-tools.make
index 42b48b2c5..f34efb50f 100644
--- a/rules/host-squashfs-tools.make
+++ b/rules/host-squashfs-tools.make
@@ -22,8 +22,8 @@ HOST_SQUASHFS_TOOLS_SUBDIR := squashfs-tools
# ----------------------------------------------------------------------------
HOST_SQUASHFS_TOOLS_MAKE_OPT := \
- LZO_SUPPORT=1 \
- XZ_SUPPORT=1 \
+ LZO_SUPPORT=$(call ptx/ifdef, PTXCONF_HOST_SQUASHFS_TOOLS_LZO_SUPPORT,1,0) \
+ XZ_SUPPORT=$(call ptx/ifdef, PTXCONF_HOST_SQUASHFS_TOOLS_XZ_SUPPORT,1,0) \
ZSTD_SUPPORT=$(call ptx/ifdef, PTXCONF_HOST_SQUASHFS_TOOLS_ZSTD_SUPPORT,1,0)
HOST_SQUASHFS_TOOLS_MAKE_ENV := $(HOST_ENV) EXTRA_LDFLAGS="-L$(PTXDIST_SYSROOT_HOST)/lib/xz"
--
2.26.2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-07-24 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 15:50 [ptxdist] [PATCH v3 1/5] host-zstd: new package Bruno Thomsen
2020-07-24 15:51 ` [ptxdist] [PATCH v3 2/5] host-squashfs-tools: add support for zstd contitional Bruno Thomsen
2020-08-03 6:29 ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-24 15:51 ` [ptxdist] [PATCH v3 3/5] image-root-squashfs: add zstd compression option Bruno Thomsen
2020-08-03 6:30 ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-24 15:51 ` Bruno Thomsen [this message]
2020-08-03 6:30 ` [ptxdist] [APPLIED] host-squashfs-tools: conditional select lzo and xz dependencies Michael Olbrich
2020-07-24 15:51 ` [ptxdist] [PATCH v3 5/5] host-squashfs-tools: fix lz4 compression option Bruno Thomsen
2020-08-03 6:30 ` [ptxdist] [APPLIED] " Michael Olbrich
2020-08-03 6:29 ` [ptxdist] [APPLIED] host-zstd: new package Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724155103.6374-4-bruno.thomsen@gmail.com \
--to=bruno.thomsen@gmail.com \
--cc=bth@kamstrup.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox