Re: [ptxdist] [PATCH v2 4/5] host-squashfs-tools: conditional select lzo and xz dependencies

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Jul 20, 2020 at 04:50:31PM +0200, Bruno Thomsen wrote:
> Only select host lzo and host xz packages when needed to
> speed up complete build time and avoid unnecessary dependencies.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> No changes since version 1.
> 
>  rules/host-squashfs-tools.in   | 4 ++--
>  rules/host-squashfs-tools.make | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/rules/host-squashfs-tools.in b/rules/host-squashfs-tools.in
> index 5ea45120e..9e50784dd 100644
> --- a/rules/host-squashfs-tools.in
> +++ b/rules/host-squashfs-tools.in
> @@ -3,7 +3,7 @@
>  config HOST_SQUASHFS_TOOLS
>  	tristate
>  	select HOST_ZLIB
> -	select HOST_LIBLZO
> -	select HOST_XZ
> +	select HOST_LIBLZO	if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_LZO
> +	select HOST_XZ		if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_XZ
>  	select HOST_ZSTD	if IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD
>  	default y if ALLYES
> diff --git a/rules/host-squashfs-tools.make b/rules/host-squashfs-tools.make
> index 1f3f54390..42d24ad89 100644
> --- a/rules/host-squashfs-tools.make
> +++ b/rules/host-squashfs-tools.make
> @@ -22,8 +22,8 @@ HOST_SQUASHFS_TOOLS_SUBDIR	:= squashfs-tools
>  # ----------------------------------------------------------------------------
>  
>  HOST_SQUASHFS_TOOLS_MAKE_OPT := \
> -	LZO_SUPPORT=1 \
> -	XZ_SUPPORT=1 \
> +	LZO_SUPPORT=$(call ptx/ifdef, PTXCONF_IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_LZO,1,0) \
> +	XZ_SUPPORT=$(call ptx/ifdef, PTXCONF_IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_XZ,1,0) \

Same thing as with zstd.

Michael

>  	ZSTD_SUPPORT=$(call ptx/ifdef, PTXCONF_IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD,1,0)
>  
>  HOST_SQUASHFS_TOOLS_MAKE_ENV := $(HOST_ENV) EXTRA_LDFLAGS="-L$(PTXDIST_SYSROOT_HOST)/lib/xz"
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de