From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Wed, 22 Jul 2020 11:51:30 +0200 From: Roland Hieber Message-ID: <20200722095130.fw5rclsoneafuqpt@pengutronix.de> References: <20200720115117.21293-1-rhi@pengutronix.de> <20200720125933.GA7949@pengutronix.de> <20200720211428.GA13160@lenoch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200720211428.GA13160@lenoch> Subject: Re: [ptxdist] [PATCH 1/3] gpsd: merge GPSD_SYSTEMD and GPSD_SYSTEMD_UNIT options List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ladis@linux-mips.org Cc: ptxdist@pengutronix.de On Mon, Jul 20, 2020 at 11:14:28PM +0200, ladis@linux-mips.org wrote: > On Mon, Jul 20, 2020 at 02:59:33PM +0200, Michael Olbrich wrote: > > On Mon, Jul 20, 2020 at 01:51:15PM +0200, Roland Hieber wrote: > > > The current systemd socket unit relies on compiled-in systemd support in > > > the gpsd binary, so we would need to enable GPSD_SYSTEMD with > > > GPSD_SYSTEMD_UNIT anyways. Vice versa, there is no use in having > > > compiled-in systemd socket activation support without the systemd socket > > > unit. Merge both options. > > > > It can be useful to disable systemd units but not the support. E.g. if the > > service should not be enabled by default. > > I'd prefer remove the prompt for GPSD_SYSTEMD instead and enable it with > > systemd (like rsyslog handles this, for example). > > +1 > Also please note gpsd is about to make release: > https://lists.nongnu.org/archive/html/gpsd-dev/2020-07/msg00011.html > Looks good so far, only 0101-SConstruct-Search-for-ncursesw-pkgconfig.patch > is needed and it is PTXdist specific. > > But maybye it would be worth checking all options and do transition at once. My customer just notified me that they want to move away from gpsd, so I don't think I can justify time for that :-/ Anyway, I'll still send a v2 of this series. - Roland -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de