From: Roland Hieber <rhi@pengutronix.de>
To: ladis@linux-mips.org
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/3] gpsd: merge GPSD_SYSTEMD and GPSD_SYSTEMD_UNIT options
Date: Wed, 22 Jul 2020 11:51:30 +0200 [thread overview]
Message-ID: <20200722095130.fw5rclsoneafuqpt@pengutronix.de> (raw)
In-Reply-To: <20200720211428.GA13160@lenoch>
On Mon, Jul 20, 2020 at 11:14:28PM +0200, ladis@linux-mips.org wrote:
> On Mon, Jul 20, 2020 at 02:59:33PM +0200, Michael Olbrich wrote:
> > On Mon, Jul 20, 2020 at 01:51:15PM +0200, Roland Hieber wrote:
> > > The current systemd socket unit relies on compiled-in systemd support in
> > > the gpsd binary, so we would need to enable GPSD_SYSTEMD with
> > > GPSD_SYSTEMD_UNIT anyways. Vice versa, there is no use in having
> > > compiled-in systemd socket activation support without the systemd socket
> > > unit. Merge both options.
> >
> > It can be useful to disable systemd units but not the support. E.g. if the
> > service should not be enabled by default.
> > I'd prefer remove the prompt for GPSD_SYSTEMD instead and enable it with
> > systemd (like rsyslog handles this, for example).
>
> +1
> Also please note gpsd is about to make release:
> https://lists.nongnu.org/archive/html/gpsd-dev/2020-07/msg00011.html
> Looks good so far, only 0101-SConstruct-Search-for-ncursesw-pkgconfig.patch
> is needed and it is PTXdist specific.
>
> But maybye it would be worth checking all options and do transition at once.
My customer just notified me that they want to move away from gpsd, so I
don't think I can justify time for that :-/ Anyway, I'll still send a v2
of this series.
- Roland
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-07-22 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 11:51 Roland Hieber
2020-07-20 11:51 ` [ptxdist] [PATCH 2/3] gpsd: make 'ublox' driver option more recognizable Roland Hieber
2020-07-20 11:51 ` [ptxdist] [PATCH 3/3] gpsd: fix usage of GPSD_DRIVER_NTRIP option Roland Hieber
2020-07-20 12:59 ` [ptxdist] [PATCH 1/3] gpsd: merge GPSD_SYSTEMD and GPSD_SYSTEMD_UNIT options Michael Olbrich
2020-07-20 21:14 ` ladis
2020-07-22 9:51 ` Roland Hieber [this message]
2020-07-22 9:53 ` [ptxdist] [PATCH v2 1/3] gpsd: make 'ublox' driver option more recognizable Roland Hieber
2020-07-22 9:53 ` [ptxdist] [PATCH v2 2/3] gpsd: fix usage of GPSD_DRIVER_NTRIP option Roland Hieber
2020-08-03 6:29 ` [ptxdist] [APPLIED] " Michael Olbrich
2020-07-22 9:53 ` [ptxdist] [PATCH v2 3/3] gpsd: make GPSD_SYSTEMD promptless and fix dependency Roland Hieber
2020-08-03 6:29 ` [ptxdist] [APPLIED] " Michael Olbrich
2020-08-03 6:29 ` [ptxdist] [APPLIED] gpsd: make 'ublox' driver option more recognizable Michael Olbrich
2020-08-02 14:43 ` [ptxdist] [PATCH 1/3] gpsd: merge GPSD_SYSTEMD and GPSD_SYSTEMD_UNIT options ladis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722095130.fw5rclsoneafuqpt@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=ladis@linux-mips.org \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox