From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eddie.linux-mips.org ([148.251.95.138] helo=cvs.linux-mips.org) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1jxd7I-0006r6-OH for ptxdist@pengutronix.de; Mon, 20 Jul 2020 23:14:33 +0200 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23993073AbgGTVOah6E0Q (ORCPT ); Mon, 20 Jul 2020 23:14:30 +0200 Date: Mon, 20 Jul 2020 23:14:28 +0200 From: ladis@linux-mips.org Message-ID: <20200720211428.GA13160@lenoch> References: <20200720115117.21293-1-rhi@pengutronix.de> <20200720125933.GA7949@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200720125933.GA7949@pengutronix.de> Subject: Re: [ptxdist] [PATCH 1/3] gpsd: merge GPSD_SYSTEMD and GPSD_SYSTEMD_UNIT options List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Mon, Jul 20, 2020 at 02:59:33PM +0200, Michael Olbrich wrote: > On Mon, Jul 20, 2020 at 01:51:15PM +0200, Roland Hieber wrote: > > The current systemd socket unit relies on compiled-in systemd support in > > the gpsd binary, so we would need to enable GPSD_SYSTEMD with > > GPSD_SYSTEMD_UNIT anyways. Vice versa, there is no use in having > > compiled-in systemd socket activation support without the systemd socket > > unit. Merge both options. > > It can be useful to disable systemd units but not the support. E.g. if the > service should not be enabled by default. > I'd prefer remove the prompt for GPSD_SYSTEMD instead and enable it with > systemd (like rsyslog handles this, for example). +1 Also please note gpsd is about to make release: https://lists.nongnu.org/archive/html/gpsd-dev/2020-07/msg00011.html Looks good so far, only 0101-SConstruct-Search-for-ncursesw-pkgconfig.patch is needed and it is PTXdist specific. But maybye it would be worth checking all options and do transition at once. > Michael _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de