[ptxdist] [PATCH] dhcp: add -fcommon to CFLAGS

[ptxdist] [PATCH] dhcp: add -fcommon to CFLAGS

[Philipp Zabel]

Quick workaround to fix building with GCC 10.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 rules/dhcp.make | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/dhcp.make b/rules/dhcp.make
index e131d3e9fe96..6677c2dc473c 100644
--- a/rules/dhcp.make
+++ b/rules/dhcp.make
@@ -39,9 +39,9 @@ DHCP_AUTOCONF := \
 	$(CROSS_AUTOCONF_USR) \
 	--$(call ptx/endis, PTXCONF_GLOBAL_IPV6)-dhcpv6
 
-# overwrite CFLAGS to remove -Werror
+# overwrite CFLAGS to remove -Werror, add -fcommon
 DHCP_MAKE_OPT := \
-	CFLAGS="-g -O2  -Wall -fno-strict-aliasing"
+	CFLAGS="-g -O2  -Wall -fno-strict-aliasing -fcommon"
 
 # ----------------------------------------------------------------------------
 # Target-Install
-- 
2.20.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] dhcp: add -fcommon to CFLAGS

[Michael Olbrich]

On Tue, Jul 07, 2020 at 12:44:17PM +0200, Philipp Zabel wrote:
> Quick workaround to fix building with GCC 10.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  rules/dhcp.make | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/dhcp.make b/rules/dhcp.make
> index e131d3e9fe96..6677c2dc473c 100644
> --- a/rules/dhcp.make
> +++ b/rules/dhcp.make
> @@ -39,9 +39,9 @@ DHCP_AUTOCONF := \
>  	$(CROSS_AUTOCONF_USR) \
>  	--$(call ptx/endis, PTXCONF_GLOBAL_IPV6)-dhcpv6
>  
> -# overwrite CFLAGS to remove -Werror
> +# overwrite CFLAGS to remove -Werror, add -fcommon
>  DHCP_MAKE_OPT := \
> -	CFLAGS="-g -O2  -Wall -fno-strict-aliasing"
> +	CFLAGS="-g -O2  -Wall -fno-strict-aliasing -fcommon"

No. This package needs updating. The version we use right now is almost a
decade old and there is a new release from this year.

Michael

>  
>  # ----------------------------------------------------------------------------
>  # Target-Install
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de