[ptxdist] [PATCH v2] sqlite: config: enable foreign keys by default

[ptxdist] [PATCH v2] sqlite: config: enable foreign keys by default

[Bruno Thomsen]

Support for foreign_keys pragma is already enabled at compile
time. This allows turning on the feature by default on new
database connections.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
Changes since version 1:
- Make parameter a config option.

 rules/sqlite.in   | 8 ++++++++
 rules/sqlite.make | 1 +
 2 files changed, 9 insertions(+)

diff --git a/rules/sqlite.in b/rules/sqlite.in
index 7b60edf3e..e6e01ba97 100644
--- a/rules/sqlite.in
+++ b/rules/sqlite.in
@@ -30,6 +30,14 @@ config SQLITE_READLINE
 	help
 	  Enable readline support
 
+config SQLITE_FOREIGN_KEYS
+	bool
+	prompt "enable foreign keys by default"
+	help
+	  Enable foreign keys support by default on database
+	  connections. This ensures database schema constrains
+	  are enforced by default e.g. consistency between tables.
+
 comment "install options"
 
 config SQLITE_TOOL
diff --git a/rules/sqlite.make b/rules/sqlite.make
index b23c2d377..67a66a371 100644
--- a/rules/sqlite.make
+++ b/rules/sqlite.make
@@ -45,6 +45,7 @@ SQLITE_CONF_ENV := \
 	-DSQLITE_ENABLE_COLUMN_METADATA=1 \
 	-DSQLITE_ENABLE_FTS3_PARENTHESIS=1 \
 	-DSQLITE_ENABLE_UNLOCK_NOTIFY=1 \
+	-DSQLITE_DEFAULT_FOREIGN_KEYS=$(call ptx/ifdef, PTXCONF_SQLITE_FOREIGN_KEYS,1,0) \
 	-DSQLITE_SOUNDEX=1 \
 	"
 

base-commit: 9fe5462616de2ce93663f409f471ea83a6d5fbb5
-- 
2.26.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [APPLIED] sqlite: config: enable foreign keys by default

[Michael Olbrich]

Thanks, applied as b550c0d4eea7aca5453d3ead7247557b0c96a014.

Michael

[sent from post-receive hook]

On Tue, 04 Aug 2020 09:23:24 +0200, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> Support for foreign_keys pragma is already enabled at compile
> time. This allows turning on the feature by default on new
> database connections.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Message-Id: <20200716172913.6053-1-bruno.thomsen@gmail.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/sqlite.in b/rules/sqlite.in
> index 7b60edf3e772..e6e01ba97d6d 100644
> --- a/rules/sqlite.in
> +++ b/rules/sqlite.in
> @@ -30,6 +30,14 @@ config SQLITE_READLINE
>  	help
>  	  Enable readline support
>  
> +config SQLITE_FOREIGN_KEYS
> +	bool
> +	prompt "enable foreign keys by default"
> +	help
> +	  Enable foreign keys support by default on database
> +	  connections. This ensures database schema constrains
> +	  are enforced by default e.g. consistency between tables.
> +
>  comment "install options"
>  
>  config SQLITE_TOOL
> diff --git a/rules/sqlite.make b/rules/sqlite.make
> index b23c2d377767..67a66a3718f1 100644
> --- a/rules/sqlite.make
> +++ b/rules/sqlite.make
> @@ -45,6 +45,7 @@ SQLITE_CONF_ENV := \
>  	-DSQLITE_ENABLE_COLUMN_METADATA=1 \
>  	-DSQLITE_ENABLE_FTS3_PARENTHESIS=1 \
>  	-DSQLITE_ENABLE_UNLOCK_NOTIFY=1 \
> +	-DSQLITE_DEFAULT_FOREIGN_KEYS=$(call ptx/ifdef, PTXCONF_SQLITE_FOREIGN_KEYS,1,0) \
>  	-DSQLITE_SOUNDEX=1 \
>  	"
>  

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de