From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jw6Rz-0003jK-Sd for ptxdist@pengutronix.de; Thu, 16 Jul 2020 18:09:35 +0200 Received: from mol by dude02.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jw6Rz-0005br-Kd for ptxdist@pengutronix.de; Thu, 16 Jul 2020 18:09:35 +0200 Date: Thu, 16 Jul 2020 18:09:35 +0200 From: Michael Olbrich Message-ID: <20200716160935.GA6174@pengutronix.de> References: <20200710155553.6370-1-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200710155553.6370-1-bruno.thomsen@gmail.com> Subject: Re: [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT commands via DBus List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Jul 10, 2020 at 05:55:53PM +0200, Bruno Thomsen wrote: > This feature is useful when needing to approve a device > under RED directive for the EU market where it's required > to use the same firmware that ships to customers during > radio testing. As this work typically involves the use of > hidden/custom commands not need for every day operation. > > Signed-off-by: Bruno Thomsen > --- > v1-v2: > rhi: use select DBUS dependency. > > rules/modemmanager.in | 5 +++++ > rules/modemmanager.make | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/rules/modemmanager.in b/rules/modemmanager.in > index 50f2d9c6a..179932835 100644 > --- a/rules/modemmanager.in > +++ b/rules/modemmanager.in > @@ -2,6 +2,7 @@ > > menuconfig MODEMMANAGER > tristate > + select DBUS if MODEMMANAGER_ALLOW_DBUS_AT_CMDS This is a runtime dependency, not a buildtime dependency, right? select DBUS if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME Michael > select GLIB > select UDEV > select LIBGUDEV > @@ -24,4 +25,8 @@ config MODEMMANAGER_SYSTEMD_UNIT > depends on SYSTEMD > prompt "install systemd unit file" > > +config MODEMMANAGER_ALLOW_DBUS_AT_CMDS > + bool > + prompt "allow arbitrary AT commands via DBus" > + > endif > diff --git a/rules/modemmanager.make b/rules/modemmanager.make > index b26e47c4a..5cae10024 100644 > --- a/rules/modemmanager.make > +++ b/rules/modemmanager.make > @@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT := \ > --$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \ > --$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \ > --without-polkit \ > - --without-at-command-via-dbus \ > + --$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \ > --with-mbim \ > --with-qmi > > > base-commit: 9fe5462616de2ce93663f409f471ea83a6d5fbb5 > -- > 2.26.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de