Re: [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT commands via DBus

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jul 10, 2020 at 05:55:53PM +0200, Bruno Thomsen wrote:
> This feature is useful when needing to approve a device
> under RED directive for the EU market where it's required
> to use the same firmware that ships to customers during
> radio testing. As this work typically involves the use of
> hidden/custom commands not need for every day operation.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> v1-v2:
> rhi: use select DBUS dependency.
> 
>  rules/modemmanager.in   | 5 +++++
>  rules/modemmanager.make | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> index 50f2d9c6a..179932835 100644
> --- a/rules/modemmanager.in
> +++ b/rules/modemmanager.in
> @@ -2,6 +2,7 @@
>  
>  menuconfig MODEMMANAGER
>  	tristate
> +	select DBUS		if MODEMMANAGER_ALLOW_DBUS_AT_CMDS

This is a runtime dependency, not a buildtime dependency, right?

	select DBUS		if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME

Michael


>  	select GLIB
>  	select UDEV
>  	select LIBGUDEV
> @@ -24,4 +25,8 @@ config MODEMMANAGER_SYSTEMD_UNIT
>  	depends on SYSTEMD
>  	prompt "install systemd unit file"
>  
> +config MODEMMANAGER_ALLOW_DBUS_AT_CMDS
> +	bool
> +	prompt "allow arbitrary AT commands via DBus"
> +
>  endif
> diff --git a/rules/modemmanager.make b/rules/modemmanager.make
> index b26e47c4a..5cae10024 100644
> --- a/rules/modemmanager.make
> +++ b/rules/modemmanager.make
> @@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT	:= \
>  	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \
>  	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \
>  	--without-polkit \
> -	--without-at-command-via-dbus \
> +	--$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \
>  	--with-mbim \
>  	--with-qmi
>  
> 
> base-commit: 9fe5462616de2ce93663f409f471ea83a6d5fbb5
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de