mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>,
	rhi@pengutronix.de, bth@kamstrup.com
Subject: [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT commands via DBus
Date: Fri, 10 Jul 2020 17:55:53 +0200	[thread overview]
Message-ID: <20200710155553.6370-1-bruno.thomsen@gmail.com> (raw)

This feature is useful when needing to approve a device
under RED directive for the EU market where it's required
to use the same firmware that ships to customers during
radio testing. As this work typically involves the use of
hidden/custom commands not need for every day operation.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
v1-v2:
rhi: use select DBUS dependency.

 rules/modemmanager.in   | 5 +++++
 rules/modemmanager.make | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/rules/modemmanager.in b/rules/modemmanager.in
index 50f2d9c6a..179932835 100644
--- a/rules/modemmanager.in
+++ b/rules/modemmanager.in
@@ -2,6 +2,7 @@
 
 menuconfig MODEMMANAGER
 	tristate
+	select DBUS		if MODEMMANAGER_ALLOW_DBUS_AT_CMDS
 	select GLIB
 	select UDEV
 	select LIBGUDEV
@@ -24,4 +25,8 @@ config MODEMMANAGER_SYSTEMD_UNIT
 	depends on SYSTEMD
 	prompt "install systemd unit file"
 
+config MODEMMANAGER_ALLOW_DBUS_AT_CMDS
+	bool
+	prompt "allow arbitrary AT commands via DBus"
+
 endif
diff --git a/rules/modemmanager.make b/rules/modemmanager.make
index b26e47c4a..5cae10024 100644
--- a/rules/modemmanager.make
+++ b/rules/modemmanager.make
@@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT	:= \
 	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \
 	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \
 	--without-polkit \
-	--without-at-command-via-dbus \
+	--$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \
 	--with-mbim \
 	--with-qmi
 

base-commit: 9fe5462616de2ce93663f409f471ea83a6d5fbb5
-- 
2.26.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

             reply	other threads:[~2020-07-10 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10 15:55 Bruno Thomsen [this message]
2020-07-16 16:09 ` Michael Olbrich
2020-07-17  6:32   ` Bruno Thomsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200710155553.6370-1-bruno.thomsen@gmail.com \
    --to=bruno.thomsen@gmail.com \
    --cc=bth@kamstrup.com \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox