Re: [ptxdist] [PATCH] modemmanager: config: allow arbitrary AT commands via DBus

[Roland Hieber <rhi@pengutronix.de>]

On Thu, Jul 09, 2020 at 05:31:07PM +0200, Bruno Thomsen wrote:
> This feature is useful when needing to approve a device
> under RED directive for the EU market where it's required
> to use the same firmware that ships to customers during
> radio testing. As this work typically involves the use of
> hidden/custom commands not need for every day operation.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
>  rules/modemmanager.in   | 5 +++++
>  rules/modemmanager.make | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> index 50f2d9c6a..20da8d5fd 100644
> --- a/rules/modemmanager.in
> +++ b/rules/modemmanager.in
> @@ -24,4 +24,9 @@ config MODEMMANAGER_SYSTEMD_UNIT
>  	depends on SYSTEMD
>  	prompt "install systemd unit file"
>  
> +config MODEMMANAGER_ALLOW_DBUS_AT_CMDS
> +	bool
> +	depends on SYSTEMD

Should this be a DBUS instead of a SYSTEMD? If so, I would rather
formulate is as a select dependency.

 - Roland

> +	prompt "allow arbitrary AT commands via DBus"
> +
>  endif
> diff --git a/rules/modemmanager.make b/rules/modemmanager.make
> index b26e47c4a..5cae10024 100644
> --- a/rules/modemmanager.make
> +++ b/rules/modemmanager.make
> @@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT	:= \
>  	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \
>  	--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \
>  	--without-polkit \
> -	--without-at-command-via-dbus \
> +	--$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \
>  	--with-mbim \
>  	--with-qmi
>  
> 
> base-commit: 9fe5462616de2ce93663f409f471ea83a6d5fbb5
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de