From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jsUPb-0005rX-9k for ptxdist@pengutronix.de; Mon, 06 Jul 2020 18:56:11 +0200 Received: from mol by dude02.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jsUPa-00035C-W1 for ptxdist@pengutronix.de; Mon, 06 Jul 2020 18:56:11 +0200 Date: Mon, 6 Jul 2020 18:56:10 +0200 From: Michael Olbrich Message-ID: <20200706165610.GD19479@pengutronix.de> References: <20200706152441.4200-1-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200706152441.4200-1-bruno.thomsen@gmail.com> Subject: Re: [ptxdist] [PATCH] bugfix: kernel: install modules with 755 permission List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Mon, Jul 06, 2020 at 05:24:41PM +0200, Bruno Thomsen wrote: > Added install_copy fixes errors like this: > > Incompatible ownership or permissions for '/usr/lib/modules/5.6.13-gb44726ddbb7c': > kernel-modules: 0.0 0755 (implicit from /usr/lib/modules/5.6.13-gb44726ddbb7c/kernel/net/ipv6/ip6_udp_tunnel.ko) > kernel-modules: 0.0 0775 Hmmm, you're running ptxdist with a 0002 umask, right?[1] Also, the fix is not clear to me. The error is for /usr/lib/modules/5.6.13-gb44726ddbb7c but you're creating /usr/lib/modules explicitly. How does that fix the problem? Michael [1] https://www.ptxdist.org/doc/daily_work_section.html#umask-pitfall > > Modified install_glob fixes this error: > > Collected errors: > * check_data_file_clashes: Package usr-rootfs wants to install file ../platform-x/build-target/image-root-tgz/lib > But that path is currently a directory > * opkg_solver_install: Cannot install package usr-rootfs. > > Signed-off-by: Bruno Thomsen > --- > rules/kernel.make | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/rules/kernel.make b/rules/kernel.make > index 0d9710828..66222f386 100644 > --- a/rules/kernel.make > +++ b/rules/kernel.make > @@ -308,8 +308,9 @@ ifdef PTXCONF_KERNEL_MODULES_INSTALL > @$(call install_fixup, kernel-modules, AUTHOR,"Robert Schwebel ") > @$(call install_fixup, kernel-modules, DESCRIPTION,missing) > > - @$(call install_glob, kernel-modules, 0, 0, -, /lib/modules, *.ko,, k) > - @$(call install_glob, kernel-modules, 0, 0, -, /lib/modules,, *.ko */build */source, n) > + @$(call install_copy, kernel-modules, 0, 0, 755, /usr/lib/modules) > + @$(call install_glob, kernel-modules, 0, 0, /lib/modules, /usr/lib/modules, *.ko,, k) > + @$(call install_glob, kernel-modules, 0, 0, /lib/modules, /usr/lib/modules,, *.ko */build */source, n) > > @$(call install_finish, kernel-modules) > endif > > base-commit: 1ec4ca50586575426ed9732c8e335b05df0b4f6a > -- > 2.26.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de