* [ptxdist] [PATCH] host-libcap: disable go binding
@ 2020-07-03 8:43 ladis
2020-07-03 9:30 ` Michael Olbrich
2020-07-06 6:32 ` [ptxdist] [APPLIED] " Michael Olbrich
0 siblings, 2 replies; 5+ messages in thread
From: ladis @ 2020-07-03 8:43 UTC (permalink / raw)
To: ptxdist
It is not needed and saves compilation time.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
Hi,
to be honest, the true motivation for this patch is:
make[1]: Leaving directory '.../build-host/libcap-2.36/libcap'
make -C go all
make[1]: Entering directory '.../build-host/libcap-2.36/go'
mkdir -p src/libcap
make[1]: *** No rule to make target 'src/libcap/psx/psx.go', needed by 'pkg/linux_amd64/libcap/psx.a'. Stop.
I'm not sure what problem on Debian unstable is, so let's disable
golang support.
rules/host-libcap.make | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/rules/host-libcap.make b/rules/host-libcap.make
index 61df84778..d92882a16 100644
--- a/rules/host-libcap.make
+++ b/rules/host-libcap.make
@@ -16,7 +16,12 @@ HOST_PACKAGES-$(PTXCONF_HOST_LIBCAP) += host-libcap
# Prepare
# ----------------------------------------------------------------------------
-HOST_LIBCAP_MAKE_OPT := prefix= BUILD_GPERF=no PAM_CAP=no LIBATTR=no DYNAMIC=yes lib=lib
+HOST_LIBCAP_MAKE_OPT := prefix= lib=lib \
+ BUILD_GPERF=no \
+ PAM_CAP=no \
+ GOLANG=no \
+ LIBATTR=no \
+ DYNAMIC=yes
HOST_LIBCAP_INSTALL_OPT := $(HOST_LIBCAP_MAKE_OPT) RAISE_SETFCAP=no install
# vim: syntax=make
--
2.27.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] host-libcap: disable go binding
2020-07-03 8:43 [ptxdist] [PATCH] host-libcap: disable go binding ladis
@ 2020-07-03 9:30 ` Michael Olbrich
2020-07-03 9:34 ` ladis
2020-07-06 6:32 ` [ptxdist] [APPLIED] " Michael Olbrich
1 sibling, 1 reply; 5+ messages in thread
From: Michael Olbrich @ 2020-07-03 9:30 UTC (permalink / raw)
To: ptxdist
On Fri, Jul 03, 2020 at 10:43:42AM +0200, ladis@linux-mips.org wrote:
> It is not needed and saves compilation time.
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
> Hi,
>
> to be honest, the true motivation for this patch is:
> make[1]: Leaving directory '.../build-host/libcap-2.36/libcap'
> make -C go all
> make[1]: Entering directory '.../build-host/libcap-2.36/go'
> mkdir -p src/libcap
> make[1]: *** No rule to make target 'src/libcap/psx/psx.go', needed by 'pkg/linux_amd64/libcap/psx.a'. Stop.
> I'm not sure what problem on Debian unstable is, so let's disable
> golang support.
Hu, I probably never noticed because I don't have the necessary go stuff
installed. But either reasons is good, so I've queued this now.
Michael
> rules/host-libcap.make | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/rules/host-libcap.make b/rules/host-libcap.make
> index 61df84778..d92882a16 100644
> --- a/rules/host-libcap.make
> +++ b/rules/host-libcap.make
> @@ -16,7 +16,12 @@ HOST_PACKAGES-$(PTXCONF_HOST_LIBCAP) += host-libcap
> # Prepare
> # ----------------------------------------------------------------------------
>
> -HOST_LIBCAP_MAKE_OPT := prefix= BUILD_GPERF=no PAM_CAP=no LIBATTR=no DYNAMIC=yes lib=lib
> +HOST_LIBCAP_MAKE_OPT := prefix= lib=lib \
> + BUILD_GPERF=no \
> + PAM_CAP=no \
> + GOLANG=no \
> + LIBATTR=no \
> + DYNAMIC=yes
> HOST_LIBCAP_INSTALL_OPT := $(HOST_LIBCAP_MAKE_OPT) RAISE_SETFCAP=no install
>
> # vim: syntax=make
> --
> 2.27.0
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] host-libcap: disable go binding
2020-07-03 9:30 ` Michael Olbrich
@ 2020-07-03 9:34 ` ladis
2020-07-03 9:40 ` Michael Olbrich
0 siblings, 1 reply; 5+ messages in thread
From: ladis @ 2020-07-03 9:34 UTC (permalink / raw)
To: ptxdist
On Fri, Jul 03, 2020 at 11:30:40AM +0200, Michael Olbrich wrote:
> On Fri, Jul 03, 2020 at 10:43:42AM +0200, ladis@linux-mips.org wrote:
> > It is not needed and saves compilation time.
> >
> > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > ---
> > Hi,
> >
> > to be honest, the true motivation for this patch is:
> > make[1]: Leaving directory '.../build-host/libcap-2.36/libcap'
> > make -C go all
> > make[1]: Entering directory '.../build-host/libcap-2.36/go'
> > mkdir -p src/libcap
> > make[1]: *** No rule to make target 'src/libcap/psx/psx.go', needed by 'pkg/linux_amd64/libcap/psx.a'. Stop.
> > I'm not sure what problem on Debian unstable is, so let's disable
> > golang support.
>
> Hu, I probably never noticed because I don't have the necessary go stuff
> installed. But either reasons is good, so I've queued this now.
The same problem shows up with libcap package, where I solved it
with "libcap: add PAM support" patch. Now, after enough coffee I feel
sorry for such a poor job and I'm ready to split it up into separate
patch if you wish so :)
ladis
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] host-libcap: disable go binding
2020-07-03 9:34 ` ladis
@ 2020-07-03 9:40 ` Michael Olbrich
0 siblings, 0 replies; 5+ messages in thread
From: Michael Olbrich @ 2020-07-03 9:40 UTC (permalink / raw)
To: ptxdist
On Fri, Jul 03, 2020 at 11:34:46AM +0200, ladis@linux-mips.org wrote:
> On Fri, Jul 03, 2020 at 11:30:40AM +0200, Michael Olbrich wrote:
> > On Fri, Jul 03, 2020 at 10:43:42AM +0200, ladis@linux-mips.org wrote:
> > > It is not needed and saves compilation time.
> > >
> > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > > ---
> > > Hi,
> > >
> > > to be honest, the true motivation for this patch is:
> > > make[1]: Leaving directory '.../build-host/libcap-2.36/libcap'
> > > make -C go all
> > > make[1]: Entering directory '.../build-host/libcap-2.36/go'
> > > mkdir -p src/libcap
> > > make[1]: *** No rule to make target 'src/libcap/psx/psx.go', needed by 'pkg/linux_amd64/libcap/psx.a'. Stop.
> > > I'm not sure what problem on Debian unstable is, so let's disable
> > > golang support.
> >
> > Hu, I probably never noticed because I don't have the necessary go stuff
> > installed. But either reasons is good, so I've queued this now.
>
> The same problem shows up with libcap package, where I solved it
> with "libcap: add PAM support" patch.
Right. The go detection doesn't care about cross-compiling... :-/
> Now, after enough coffee I feel
> sorry for such a poor job and I'm ready to split it up into separate
> patch if you wish so :)
We'll see. The patch is in my test queue now. If there are no problems,
then I'll merge it as it is. If I find other stuff for you to fix, then
please split it. You'll get a mail either way.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [APPLIED] host-libcap: disable go binding
2020-07-03 8:43 [ptxdist] [PATCH] host-libcap: disable go binding ladis
2020-07-03 9:30 ` Michael Olbrich
@ 2020-07-06 6:32 ` Michael Olbrich
1 sibling, 0 replies; 5+ messages in thread
From: Michael Olbrich @ 2020-07-06 6:32 UTC (permalink / raw)
To: ptxdist
Thanks, applied as a986feb514bd7ff6c75d0fb7a3fc7ea3b0169f44.
Michael
[sent from post-receive hook]
On Mon, 06 Jul 2020 08:32:01 +0200, Ladislav Michl <ladis@linux-mips.org> wrote:
> It is not needed and saves compilation time.
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> Message-Id: <20200703084342.GA154165@lenoch>
> [mol: add some more line breaks]
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/host-libcap.make b/rules/host-libcap.make
> index 61df84778d5b..2faae99c3c9a 100644
> --- a/rules/host-libcap.make
> +++ b/rules/host-libcap.make
> @@ -16,7 +16,15 @@ HOST_PACKAGES-$(PTXCONF_HOST_LIBCAP) += host-libcap
> # Prepare
> # ----------------------------------------------------------------------------
>
> -HOST_LIBCAP_MAKE_OPT := prefix= BUILD_GPERF=no PAM_CAP=no LIBATTR=no DYNAMIC=yes lib=lib
> +HOST_LIBCAP_MAKE_OPT := \
> + prefix= \
> + lib=lib \
> + BUILD_GPERF=no \
> + PAM_CAP=no \
> + GOLANG=no \
> + LIBATTR=no \
> + DYNAMIC=yes
> +
> HOST_LIBCAP_INSTALL_OPT := $(HOST_LIBCAP_MAKE_OPT) RAISE_SETFCAP=no install
>
> # vim: syntax=make
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-06 6:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-03 8:43 [ptxdist] [PATCH] host-libcap: disable go binding ladis
2020-07-03 9:30 ` Michael Olbrich
2020-07-03 9:34 ` ladis
2020-07-03 9:40 ` Michael Olbrich
2020-07-06 6:32 ` [ptxdist] [APPLIED] " Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox