From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] host-libcap: disable go binding
Date: Fri, 3 Jul 2020 11:40:38 +0200 [thread overview]
Message-ID: <20200703094038.GF24749@pengutronix.de> (raw)
In-Reply-To: <20200703093446.GA862408@lenoch>
On Fri, Jul 03, 2020 at 11:34:46AM +0200, ladis@linux-mips.org wrote:
> On Fri, Jul 03, 2020 at 11:30:40AM +0200, Michael Olbrich wrote:
> > On Fri, Jul 03, 2020 at 10:43:42AM +0200, ladis@linux-mips.org wrote:
> > > It is not needed and saves compilation time.
> > >
> > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > > ---
> > > Hi,
> > >
> > > to be honest, the true motivation for this patch is:
> > > make[1]: Leaving directory '.../build-host/libcap-2.36/libcap'
> > > make -C go all
> > > make[1]: Entering directory '.../build-host/libcap-2.36/go'
> > > mkdir -p src/libcap
> > > make[1]: *** No rule to make target 'src/libcap/psx/psx.go', needed by 'pkg/linux_amd64/libcap/psx.a'. Stop.
> > > I'm not sure what problem on Debian unstable is, so let's disable
> > > golang support.
> >
> > Hu, I probably never noticed because I don't have the necessary go stuff
> > installed. But either reasons is good, so I've queued this now.
>
> The same problem shows up with libcap package, where I solved it
> with "libcap: add PAM support" patch.
Right. The go detection doesn't care about cross-compiling... :-/
> Now, after enough coffee I feel
> sorry for such a poor job and I'm ready to split it up into separate
> patch if you wish so :)
We'll see. The patch is in my test queue now. If there are no problems,
then I'll merge it as it is. If I find other stuff for you to fix, then
please split it. You'll get a mail either way.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-07-03 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 8:43 ladis
2020-07-03 9:30 ` Michael Olbrich
2020-07-03 9:34 ` ladis
2020-07-03 9:40 ` Michael Olbrich [this message]
2020-07-06 6:32 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703094038.GF24749@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox