From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmA6I-00007m-RU for ptxdist@pengutronix.de; Fri, 19 Jun 2020 08:02:06 +0200 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jmA6I-0007PY-It for ptxdist@pengutronix.de; Fri, 19 Jun 2020 08:02:06 +0200 Date: Fri, 19 Jun 2020 08:02:06 +0200 From: Michael Olbrich Message-ID: <20200619060206.GF9312@pengutronix.de> References: <20200616105044.22952-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200616105044.22952-1-u.kleine-koenig@pengutronix.de> Subject: Re: [ptxdist] [PATCH 1/2] tpm2-abrmd: make installation of libtss2-tcti-tabrmd.so.0 conditional List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Tue, Jun 16, 2020 at 12:50:43PM +0200, Uwe Kleine-K=F6nig wrote: > Not all users of tpm2-abrmd make use of the library, so introduce a > config symbol to make it possible to not install it. No. I want to avoid additional options unless it avoids a dependency or the library is quite bit. And I don't think that's the case here. Michael > Signed-off-by: Uwe Kleine-K=F6nig > --- > rules/tpm2-abrmd.in | 7 +++++++ > rules/tpm2-abrmd.make | 2 ++ > 2 files changed, 9 insertions(+) > = > diff --git a/rules/tpm2-abrmd.in b/rules/tpm2-abrmd.in > index 1ab0a6a7fe0e..61bba8a02030 100644 > --- a/rules/tpm2-abrmd.in > +++ b/rules/tpm2-abrmd.in > @@ -16,3 +16,10 @@ config TPM2_ABRMD > (TAB) & Resource Manager (RM) spec from the TCG. The daemon > (tpm2-abrmd) is implemented using Glib and the GObject > system. > + > +if TPM2_ABRMD > + > +config TPM2_ABRMD_LIBTSS2_TCTI_TABRMD > + bool "install libtss2-tcti-tabrmd.so.0" > + > +endif > diff --git a/rules/tpm2-abrmd.make b/rules/tpm2-abrmd.make > index bbf3344126f7..edc1fcfc0e6e 100644 > --- a/rules/tpm2-abrmd.make > +++ b/rules/tpm2-abrmd.make > @@ -63,7 +63,9 @@ $(STATEDIR)/tpm2-abrmd.targetinstall: > @$(call install_fixup, tpm2-abrmd,AUTHOR,"Marc Kleine-Budde ") > @$(call install_fixup, tpm2-abrmd,DESCRIPTION,missing) > = > +ifdef PTXCONF_TPM2_ABRMD_LIBTSS2_TCTI_TABRMD > @$(call install_lib, tpm2-abrmd, 0, 0, 0644, libtss2-tcti-tabrmd) > +endif > @$(call install_copy, tpm2-abrmd, 0, 0, 0755, -, /usr/sbin/tpm2-abrmd) > = > @$(call install_alternative, tpm2-abrmd, 0, 0, 0644, \ > -- = > 2.27.0 > = > = > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request= @pengutronix.de -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@p= engutronix.de