Re: [ptxdist] [PATCH 1/2] tpm2-abrmd: make installation of libtss2-tcti-tabrmd.so.0 conditional

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Jun 16, 2020 at 12:50:43PM +0200, Uwe Kleine-König wrote:
> Not all users of tpm2-abrmd make use of the library, so introduce a
> config symbol to make it possible to not install it.

No. I want to avoid additional options unless it avoids a dependency or the
library is quite bit. And I don't think that's the case here.

Michael

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  rules/tpm2-abrmd.in   | 7 +++++++
>  rules/tpm2-abrmd.make | 2 ++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/rules/tpm2-abrmd.in b/rules/tpm2-abrmd.in
> index 1ab0a6a7fe0e..61bba8a02030 100644
> --- a/rules/tpm2-abrmd.in
> +++ b/rules/tpm2-abrmd.in
> @@ -16,3 +16,10 @@ config TPM2_ABRMD
>  	  (TAB) & Resource Manager (RM) spec from the TCG. The daemon
>  	  (tpm2-abrmd) is implemented using Glib and the GObject
>  	  system.
> +
> +if TPM2_ABRMD
> +
> +config TPM2_ABRMD_LIBTSS2_TCTI_TABRMD
> +	bool "install libtss2-tcti-tabrmd.so.0"
> +
> +endif
> diff --git a/rules/tpm2-abrmd.make b/rules/tpm2-abrmd.make
> index bbf3344126f7..edc1fcfc0e6e 100644
> --- a/rules/tpm2-abrmd.make
> +++ b/rules/tpm2-abrmd.make
> @@ -63,7 +63,9 @@ $(STATEDIR)/tpm2-abrmd.targetinstall:
>  	@$(call install_fixup, tpm2-abrmd,AUTHOR,"Marc Kleine-Budde <mkl@pengutronix.de>")
>  	@$(call install_fixup, tpm2-abrmd,DESCRIPTION,missing)
>  
> +ifdef PTXCONF_TPM2_ABRMD_LIBTSS2_TCTI_TABRMD
>  	@$(call install_lib, tpm2-abrmd, 0, 0, 0644, libtss2-tcti-tabrmd)
> +endif
>  	@$(call install_copy, tpm2-abrmd, 0, 0, 0755, -, /usr/sbin/tpm2-abrmd)
>  
>  	@$(call install_alternative, tpm2-abrmd, 0, 0, 0644, \
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de