Re: [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Jun 13, 2020 at 03:32:45AM +0200, Roland Hieber wrote:
> There is no guarantee that URLs will still work the next time we want to
> check them, so try to fetch the URL every time instead of caching the
> result. This also makes iterations of editing the URL in the rule file
> and testing if it works quicker.
> 
> Unfortunately, GNU make skips implicit rules for .PHONY targets, but it
> is unlikely that $(STATEDIR)/%.urlcheck is created by something other
> than PTXdist, so removing the $(call touch) is a good approximation for
> phony behaviour.

No. This is deliberately like this. I want to run 'ptxdist urlcheck', fix
errors and then continue with the rest.

How about an extra ptxdist options. When it is given, then all make target
that are explicitly specified on the command-line are added to the PHONY
list, so that they are always executed. Then you could do:

ptxdist --something urlcheck foobar

And you can do this multiple times. I don't have a good name for the
option. But I think this could be useful for other things as well.

Michael


> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/post/ptxd_make_world_get.make | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/rules/post/ptxd_make_world_get.make b/rules/post/ptxd_make_world_get.make
> index a2026c994591..a79b4d170873 100644
> --- a/rules/post/ptxd_make_world_get.make
> +++ b/rules/post/ptxd_make_world_get.make
> @@ -58,7 +58,6 @@ $(STATEDIR)/%.urlcheck:
>  	@$(call targetinfo)
>  	@$(foreach src,$($(PTX_MAP_TO_PACKAGE_$(*))_SOURCES), \
>  		$(call world/urlcheck, $($(src)));)
> -	@$(call touch)
>  
>  world/urlcheck = \
>  	$(call world/env, $(1)) \
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de