mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent
Date: Sat, 13 Jun 2020 03:32:45 +0200	[thread overview]
Message-ID: <20200613013249.4288-3-rhi@pengutronix.de> (raw)
In-Reply-To: <20200613013249.4288-1-rhi@pengutronix.de>

There is no guarantee that URLs will still work the next time we want to
check them, so try to fetch the URL every time instead of caching the
result. This also makes iterations of editing the URL in the rule file
and testing if it works quicker.

Unfortunately, GNU make skips implicit rules for .PHONY targets, but it
is unlikely that $(STATEDIR)/%.urlcheck is created by something other
than PTXdist, so removing the $(call touch) is a good approximation for
phony behaviour.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/post/ptxd_make_world_get.make | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rules/post/ptxd_make_world_get.make b/rules/post/ptxd_make_world_get.make
index a2026c994591..a79b4d170873 100644
--- a/rules/post/ptxd_make_world_get.make
+++ b/rules/post/ptxd_make_world_get.make
@@ -58,7 +58,6 @@ $(STATEDIR)/%.urlcheck:
 	@$(call targetinfo)
 	@$(foreach src,$($(PTX_MAP_TO_PACKAGE_$(*))_SOURCES), \
 		$(call world/urlcheck, $($(src)));)
-	@$(call touch)
 
 world/urlcheck = \
 	$(call world/env, $(1)) \
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  parent reply	other threads:[~2020-06-13  1:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-13  1:32 [ptxdist] [PATCH 1/7] setup: remove dead code Roland Hieber
2020-06-13  1:32 ` [ptxdist] [PATCH 2/7] setup: use https by default for PTXCONF_SETUP_PTXMIRROR Roland Hieber
2020-06-19 22:03   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-06-13  1:32 ` Roland Hieber [this message]
2020-06-19  5:34   ` [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent Michael Olbrich
2020-06-19  8:22     ` Roland Hieber
2020-06-19 11:07       ` Michael Olbrich
2020-06-22 10:19         ` Roland Hieber
2020-06-13  1:32 ` [ptxdist] [PATCH 4/7] ptxd_make_get: print out final redirected URL on dry run Roland Hieber
2020-06-19 22:03   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-06-13  1:32 ` [ptxdist] [PATCH 5/7] ptxd_make_get: continue with next URL when getting HTML file " Roland Hieber
2020-06-19  5:39   ` Michael Olbrich
2020-06-13  1:32 ` [ptxdist] [PATCH 6/7] libjaylink: fix URL Roland Hieber
2020-06-19  5:44   ` Michael Olbrich
2020-06-19 22:04   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-06-13  1:32 ` [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors Roland Hieber
2020-06-19  5:46   ` Michael Olbrich
2020-06-19  8:24     ` Roland Hieber
2020-06-19 11:07       ` Michael Olbrich
2020-06-28 22:07     ` Roland Hieber
2020-06-29  6:20       ` Michael Olbrich
2020-06-19 22:04   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-06-19 22:03 ` [ptxdist] [APPLIED] setup: remove dead code Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200613013249.4288-3-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox