From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eddie.linux-mips.org ([148.251.95.138] helo=cvs.linux-mips.org) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1jh8ds-0007JT-5P for ptxdist@pengutronix.de; Fri, 05 Jun 2020 11:28:00 +0200 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23991082AbgFEJ16LHcau (ORCPT ); Fri, 5 Jun 2020 11:27:58 +0200 Date: Fri, 5 Jun 2020 11:27:57 +0200 From: Ladislav Michl Message-ID: <20200605092757.GA1321273@lenoch> References: <20200604063240.GA65491@lenoch> <20200605084137.GA6064@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200605084137.GA6064@pengutronix.de> Subject: Re: [ptxdist] [PATCH] openvpn: enable iproute2 List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Jun 05, 2020 at 10:41:37AM +0200, Michael Olbrich wrote: > On Thu, Jun 04, 2020 at 08:32:40AM +0200, Ladislav Michl wrote: > > Use (rt)netlink interface provided by 'ip' tool by default. > > > > Signed-off-by: Ladislav Michl > > --- > > rules/openvpn.in | 13 +++++++------ > > rules/openvpn.make | 2 +- > > 2 files changed, 8 insertions(+), 7 deletions(-) > > > > diff --git a/rules/openvpn.in b/rules/openvpn.in > > index 6958e2940..afa124e10 100644 > > --- a/rules/openvpn.in > > +++ b/rules/openvpn.in > > @@ -9,11 +9,10 @@ menuconfig OPENVPN > > select IPTABLES if OPENVPN_INSTALL_SAMPLE_CONFIGS && RUNTIME > > select IPTABLES_INSTALL_TOOLS if OPENVPN_INSTALL_SAMPLE_CONFIGS && RUNTIME > > select BRIDGE_UTILS if OPENVPN_INSTALL_SAMPLE_SCRIPTS && RUNTIME > > - select IPROUTE2 if !BUSYBOX_IP && RUNTIME > > - select IPROUTE2_IP if !BUSYBOX_IP && RUNTIME > > - select BUSYBOX_IFCONFIG if RUNTIME > > - select BUSYBOX_NETSTAT if RUNTIME > > - select BUSYBOX_ROUTE if RUNTIME > > + select BUSYBOX_FEATURE_IP_LINK if BUSYBOX_IP && RUNTIME > > + select BUSYBOX_FEATURE_IP_ROUTE if BUSYBOX_IP && RUNTIME > > + select IPROUTE2 if !BUSYBOX && RUNTIME > > + select IPROUTE2_IP if !BUSYBOX && RUNTIME > > Why not just leave the !BUSYBOX_IP here? Then the comment below is not > needed because either IPROUTE2_IP or IPROUTE2_IP will be selected. We need to select A or B, but there is no simple way of doing this. When BUSYBOX is not used, then IPROUTE2_IP is the only option, but with BUSYBOX selected, that leads to IPROUTE2_IP being silently selected. This way user is warned about pulling another package and can act accordingly. Note that we cannot select BUSYBOX_IP anyway (circular dependency), so this is at least consistent :-) However, I do not have strong opinion here, so let me send v2. ladis _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de