Re: [ptxdist] [PATCH v2 1/3] host-gengetopt: add package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jun 03, 2020 at 10:30:51AM +0200, Marian Cichy wrote:
> 
> 
> On 6/2/20 3:18 PM, Michael Olbrich wrote:
> > On Mon, Jun 01, 2020 at 11:49:39AM +0200, Marian Cichy wrote:
> > > this package is a dependency for bayer2rgb3,
> > > which is a dependency for gst-bayer2rgb-neon
> > > ---
> > 
> > This is a v2 patch, so it should be marked as such.
> > 
> > 
> 
> I did use git format-patch -v 2 to mark it. Should I also mention v2 in the
> commit message?

Sorry, I am blind. You did the right thing here.

Michael

> > >   configs/ptxconfig         |  1 +
> > >   rules/host-gengetopt.in   |  9 +++++++++
> > >   rules/host-gengetopt.make | 26 ++++++++++++++++++++++++++
> > >   3 files changed, 36 insertions(+)
> > >   create mode 100644 rules/host-gengetopt.in
> > >   create mode 100644 rules/host-gengetopt.make
> > > 
> > > diff --git a/configs/ptxconfig b/configs/ptxconfig
> > > index 972e7615..67200af3 100644
> > > --- a/configs/ptxconfig
> > > +++ b/configs/ptxconfig
> > 
> > This file does not exist. I guess you created the patch from a BSP?
> > 
> > Michael
> > 
> 
> Yes. I thought that we need to update the ptxconfig entries with every new
> package.
> 
> > > @@ -105,6 +105,7 @@ PTXCONF__ptxconfig_MAGIC__=y
> > >   PTXCONF_HOST_BSDIFF=y
> > >   # PTXCONF_HOST_DFU_UTIL is not set
> > >   PTXCONF_HOST_FILE_STACK=y
> > > +# PTXCONF_HOST_GENGETOPT is not set
> > >   # PTXCONF_HOST_OPENOCD is not set
> > >   # PTXCONF_HOST_QEMU is not set
> > >   # PTXCONF_HOST_TESTFRAMEWORK is not set
> > > diff --git a/rules/host-gengetopt.in b/rules/host-gengetopt.in
> > > new file mode 100644
> > > index 00000000..f6855ab5
> > > --- /dev/null
> > > +++ b/rules/host-gengetopt.in
> > > @@ -0,0 +1,9 @@
> > > +## SECTION=hosttools
> > > +
> > > +config HOST_GENGETOPT
> > > +	tristate
> > > +	prompt "gengetopt"
> > > +	help
> > > +	  Gengetopt is a tool to write command line option
> > > +	  parsing code for C programs.
> > > +
> > > diff --git a/rules/host-gengetopt.make b/rules/host-gengetopt.make
> > > new file mode 100644
> > > index 00000000..2c1b3bb0
> > > --- /dev/null
> > > +++ b/rules/host-gengetopt.make
> > > @@ -0,0 +1,26 @@
> > > +# -*-makefile-*-
> > > +#
> > > +# Copyright (C) 2020 by Marian Cichy <m.cichy@pengutronix.de>
> > > +#
> > > +# For further information about the PTXdist project and license conditions
> > > +# see the README file.
> > > +#
> > > +
> > > +#
> > > +# We provide this package
> > > +#
> > > +HOST_PACKAGES-$(PTXCONF_HOST_GENGETOPT) += host-gengetopt
> > > +
> > > +#
> > > +# Paths and names
> > > +#
> > > +HOST_GENGETOPT_VERSION	:= 2.23
> > > +HOST_GENGETOPT_MD5	:= ea165d618640dbdecb42ae4491337965
> > > +HOST_GENGETOPT		:= gengetopt-$(HOST_GENGETOPT_VERSION)
> > > +HOST_GENGETOPT_SUFFIX	:= tar.xz
> > > +HOST_GENGETOPT_URL	:= https://ftp.gnu.org/gnu/gengetopt/$(HOST_GENGETOPT).$(HOST_GENGETOPT_SUFFIX)
> > > +HOST_GENGETOPT_SOURCE	:= $(SRCDIR)/$(HOST_GENGETOPT).$(HOST_GENGETOPT_SUFFIX)
> > > +HOST_GENGETOPT_DIR	:= $(HOST_BUILDDIR)/$(HOST_GENGETOPT)
> > > +HOST_GENGETOPT_LICENSE	:= GPL-3.0-only
> > > +HOST_GENGETOPT_LICENSE_FILES := file://COPYING;md5=ff95bfe019feaf92f524b73dd79e76eb
> > > +# vim: syntax=make
> > > -- 
> > > 2.20.1
> > > 
> > > 
> > > _______________________________________________
> > > ptxdist mailing list
> > > ptxdist@pengutronix.de
> > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > > 
> > 
> 
> mci
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de