Re: [ptxdist] [PATCH v2 2/3] bayer2rgb3: add package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Jun 01, 2020 at 11:49:40AM +0200, Marian Cichy wrote:
> this package is a dependency for gst-bayer2rgb-neon
> ---

Also, v2. And changes to the last version should be noted here below the
'---'. That makes review easier.

>  configs/ptxconfig                   |  1 +
>  patches/bayer2rgb3-0.4.1/autogen.sh |  1 +
>  rules/bayer2rgb3.in                 | 18 +++++++++++
>  rules/bayer2rgb3.make               | 49 +++++++++++++++++++++++++++++
>  4 files changed, 69 insertions(+)
>  create mode 120000 patches/bayer2rgb3-0.4.1/autogen.sh
>  create mode 100644 rules/bayer2rgb3.in
>  create mode 100644 rules/bayer2rgb3.make
> 
> diff --git a/configs/ptxconfig b/configs/ptxconfig
> index 67200af3..16db79a0 100644
> --- a/configs/ptxconfig
> +++ b/configs/ptxconfig

Still no ptxconfig.. :-)

> @@ -2,6 +2,7 @@
>  # Automatically generated file; DO NOT EDIT.
>  # PTXdist 2020.02.0
>  #
> +# PTXCONF_BAYER2RGB3 is not set
>  PTXCONF_BOOTCOUNT=y
>  PTXCONF_BOOTCOUNT_SYSTEMD_UNIT=y
>  PTXCONF_COMPOSE_INITRD=y
> diff --git a/patches/bayer2rgb3-0.4.1/autogen.sh b/patches/bayer2rgb3-0.4.1/autogen.sh
> new file mode 120000
> index 00000000..9f8a4cb7
> --- /dev/null
> +++ b/patches/bayer2rgb3-0.4.1/autogen.sh
> @@ -0,0 +1 @@
> +../autogen.sh
> \ No newline at end of file
> diff --git a/rules/bayer2rgb3.in b/rules/bayer2rgb3.in
> new file mode 100644
> index 00000000..7e72a5b7
> --- /dev/null
> +++ b/rules/bayer2rgb3.in
> @@ -0,0 +1,18 @@
> +## SECTION=multimedia_tools
> +
> +config BAYER2RGB3

Use menuconfig here.

> +	tristate
> +	prompt "bayer2rgb3"

add spaces at the end to align the '-->' in menuconfig. Take a look at
other packages to see what I mean.

> +	select HOST_GENGETOPT
> +	help
> +	  bayer2rgb will convert naked (no header) bayer grid data into rgb data.
> +
> +if BAYER2RGB3

blank line.

> +config BAYER2RGB3_COMMAND_TOOL
> +	bool
> +	default n

Drop this line, it's the default.

Michael

> +	prompt "bayer2rgb3 command line tool"
> +	help
> +	  install additional command line tool along the lib
> +
> +endif
> diff --git a/rules/bayer2rgb3.make b/rules/bayer2rgb3.make
> new file mode 100644
> index 00000000..8833e18b
> --- /dev/null
> +++ b/rules/bayer2rgb3.make
> @@ -0,0 +1,49 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2020 by Marian Cichy <m.cichy@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_BAYER2RGB3) += bayer2rgb3
> +
> +#
> +# Paths and names
> +#
> +BAYER2RGB3_VERSION	:= 0.4.1
> +BAYER2RGB3_MD5		:= 5362a93d4251eb012d38c1409af0182e
> +BAYER2RGB3		:= bayer2rgb3-$(BAYER2RGB3_VERSION)
> +BAYER2RGB3_SUFFIX	:= zip
> +BAYER2RGB3_URL		:= https://gitlab-ext.sigma-chemnitz.de/ensc/bayer2rgb/-/archive/master/bayer2rgb-master.zip
> +BAYER2RGB3_SOURCE	:= $(SRCDIR)/$(BAYER2RGB3).$(BAYER2RGB3_SUFFIX)
> +BAYER2RGB3_DIR		:= $(BUILDDIR)/$(BAYER2RGB3)
> +BAYER2RGB3_LICENSE	:= GPL-3.0-only
> +BAYER2RGB3_LICENSE_FILES := files://COPYING;md5sum=d32239bcb673463ab874e80d47fae504
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/bayer2rgb3.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, bayer2rgb3)
> +	@$(call install_fixup, bayer2rgb3,PRIORITY,optional)
> +	@$(call install_fixup, bayer2rgb3,SECTION,base)
> +	@$(call install_fixup, bayer2rgb3,AUTHOR,"Marian Cichy <m.cichy@pengutronix.de>")
> +	@$(call install_fixup, bayer2rgb3,DESCRIPTION,missing)
> +
> +ifdef PTXCONF_BAYER2RGB3_COMMAND_TOOL
> +	@$(call install_copy, bayer2rgb3, 0, 0, 0755, -, /usr/bin/bayer2rgb)
> +endif
> +	@$(call install_lib, bayer2rgb3, 0, 0, 0644, libbayer2rgb3)
> +
> +	@$(call install_finish, bayer2rgb3)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de