From mboxrd@z Thu Jan 1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from eddie.linux-mips.org ([148.251.95.138] helo=cvs.linux-mips.org)
by metis.ext.pengutronix.de with esmtp (Exim 4.92)
(envelope-from <ladis@linux-mips.org>) id 1jfg70-00054z-UA
for ptxdist@pengutronix.de; Mon, 01 Jun 2020 10:48:03 +0200
Received: (from localhost user: 'ladis' uid#1021 fake: STDIN
(ladis@eddie.linux-mips.org)) by eddie.linux-mips.org
id S23994079AbgFAIsALj0eI (ORCPT <rfc822;ptxdist@pengutronix.de>);
Mon, 1 Jun 2020 10:48:00 +0200
Date: Mon, 1 Jun 2020 10:47:59 +0200
From: Ladislav Michl <ladis@linux-mips.org>
Message-ID: <20200601084759.GA17168@lenoch>
References: <20191206103613.GB2137842@lenoch>
<20200106105956.GD5858@pengutronix.de>
<20200513103910.GA5308@lenoch>
<20200529080243.GC31789@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20200529080243.GC31789@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] openvpn: allow use of iproute2
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>,
<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>,
<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
On Fri, May 29, 2020 at 10:02:43AM +0200, Michael Olbrich wrote:
> On Wed, May 13, 2020 at 12:39:10PM +0200, Ladislav Michl wrote:
> > On Mon, Jan 06, 2020 at 11:59:56AM +0100, Michael Olbrich wrote:
> > > On Fri, Dec 06, 2019 at 11:36:13AM +0100, Ladislav Michl wrote:
> > > > Let OpenVPN use ip command when BUSYBOX_IP is not selected. This
> > > > allows OpenVPN to be used in Busybox-less environments.
> > >
> > > Hmmm, what does the -{en,dis}able-iproute2 option do exactly?
> > > Could we enable it unconditionally or does BUSYBOX_IP not provide all the
> > > necessary features?
> >
> > Well, what about using 'ip' by default and legacy interface as a fallback?
>
> I looked into the code and I didn't see anything that busybox ip cannot
> handle. So please keep it simple and drop the fallback.
Hmm, that would probably require some more magic as BUSYBOX_FEATURE_IP_LINK
is not selected...
Btw, looked at other packages, this is quite common problem - rauc selects
BUSYBOX_FEATURE_TAR_LONG_OPTIONS if BUSYBOX_TAR, but does not select tar
itself (neither GNU nor Busybox one)
diff --git a/rules/openvpn.in b/rules/openvpn.in
index 6958e2940..579c0314e 100644
--- a/rules/openvpn.in
+++ b/rules/openvpn.in
@@ -9,11 +9,11 @@ menuconfig OPENVPN
select IPTABLES if OPENVPN_INSTALL_SAMPLE_CONFIGS && RUNTIME
select IPTABLES_INSTALL_TOOLS if OPENVPN_INSTALL_SAMPLE_CONFIGS && RUNTIME
select BRIDGE_UTILS if OPENVPN_INSTALL_SAMPLE_SCRIPTS && RUNTIME
+ select BUSYBOX_IP if BUSYBOX && !IPROUTE2_IP && RUNTIME
+ select BUSYBOX_FEATURE_IP_LINK if BUSYBOX && BUSYBOX_IP && RUNTIME
+ select BUSYBOX_FEATURE_IP_ROUTE if BUSYBOX && BUSYBOX_IP && RUNTIME
select IPROUTE2 if !BUSYBOX_IP && RUNTIME
select IPROUTE2_IP if !BUSYBOX_IP && RUNTIME
- select BUSYBOX_IFCONFIG if RUNTIME
- select BUSYBOX_NETSTAT if RUNTIME
- select BUSYBOX_ROUTE if RUNTIME
help
virtual private network daemon
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de