Re: [ptxdist] [PATCH 2/3] bayer2rgb3: add package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, May 12, 2020 at 07:42:21PM +0200, Lucas Stach wrote:
> Am Dienstag, den 12.05.2020, 18:32 +0200 schrieb Marian Cichy:
> > ---
> >  patches/bayer2rgb3-0.4.1/autogen.sh |  1 +
> >  rules/bayer2rgb3.in                 |  8 +++++
> >  rules/bayer2rgb3.make               | 47 +++++++++++++++++++++++++++++
> >  3 files changed, 56 insertions(+)
> >  create mode 120000 patches/bayer2rgb3-0.4.1/autogen.sh
> >  create mode 100644 rules/bayer2rgb3.in
> >  create mode 100644 rules/bayer2rgb3.make
> > 
> > diff --git a/patches/bayer2rgb3-0.4.1/autogen.sh b/patches/bayer2rgb3-0.4.1/autogen.sh
> > new file mode 120000
> > index 000000000..9f8a4cb7d
> > --- /dev/null
> > +++ b/patches/bayer2rgb3-0.4.1/autogen.sh
> > @@ -0,0 +1 @@
> > +../autogen.sh
> > \ No newline at end of file
> > diff --git a/rules/bayer2rgb3.in b/rules/bayer2rgb3.in
> > new file mode 100644
> > index 000000000..8a184e577
> > --- /dev/null
> > +++ b/rules/bayer2rgb3.in
> > @@ -0,0 +1,8 @@
> > +## SECTION=multimedia_tools
> > +
> > +config BAYER2RGB3
> > +	tristate
> > +	prompt "bayer2rgb3"
> > +	select HOST_GENGETOPT
> > +	help
> > +	  bayer2rgb will convert naked (no header) bayer grid data into rgb data.
> > diff --git a/rules/bayer2rgb3.make b/rules/bayer2rgb3.make
> > new file mode 100644
> > index 000000000..28de61896
> > --- /dev/null
> > +++ b/rules/bayer2rgb3.make
> > @@ -0,0 +1,47 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2020 by Marian Cichy <m.cichy@pengutronix.de>
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_BAYER2RGB3) += bayer2rgb3
> > +
> > +#
> > +# Paths and names
> > +#
> > +BAYER2RGB3_VERSION	:= 0.4.1
> > +BAYER2RGB3_MD5		:= 5362a93d4251eb012d38c1409af0182e
> > +BAYER2RGB3		:= bayer2rgb3-$(BAYER2RGB3_VERSION)
> > +BAYER2RGB3_SUFFIX	:= zip
> > +BAYER2RGB3_URL		:= https://gitlab-ext.sigma-chemnitz.de/ensc/bayer2rgb/-/archive/master/bayer2rgb-master.zip
> > +BAYER2RGB3_SOURCE	:= $(SRCDIR)/$(BAYER2RGB3).$(BAYER2RGB3_SUFFIX)
> > +BAYER2RGB3_DIR		:= $(BUILDDIR)/$(BAYER2RGB3)
> > +BAYER2RGB3_LICENSE	:= GPL-3.0

GPL-3.0-only is the correct spdx identifier.

> > +BAYER2RGB3_LICENSE_FILES := files://COPYING;md5sum=d32239bcb673463ab874e80d47fae504
> > +
> > +# ----------------------------------------------------------------------------
> > +# Target-Install
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/bayer2rgb3.targetinstall:
> > +	@$(call targetinfo)
> > +
> > +	@$(call install_init, bayer2rgb3)
> > +	@$(call install_fixup, bayer2rgb3,PRIORITY,optional)
> > +	@$(call install_fixup, bayer2rgb3,SECTION,base)
> > +	@$(call install_fixup, bayer2rgb3,AUTHOR,"Marian Cichy <m.cichy@pengutronix.de>")
> > +	@$(call install_fixup, bayer2rgb3,DESCRIPTION,missing)
> > +
> > +	@$(call install_copy, bayer2rgb3, 0, 0, 0755, -, /usr/bin/bayer2rgb)
> 
> I guess most of the time we are not interested in this tool, but only
> the lib. I think it makes sense to add a Kconfig option to allow for
> not installing this target tool.

I agree. Please add an suboption for the tool.

Michael

> > +	@$(call install_lib, bayer2rgb3, 0, 0, 0644, libbayer2rgb3)
> > +
> > +	@$(call install_finish, bayer2rgb3)
> > +
> > +	@$(call touch)
> > +
> > +# vim: syntax=make
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de