Re: [ptxdist] [PATCH 1/2] ptxdist: add licensecheck command

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, May 25, 2020 at 11:28:19AM +0200, Roland Hieber wrote:
> Make it possible to check all MD5 sums of license files by building all
> report stages without also building the license report (which produces
> tons of LaTeX output).
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  bin/ptxdist                              | 6 ++++++
>  doc/ref_parameter.inc                    | 3 +++
>  rules/post/ptxd_make_license_report.make | 2 ++
>  3 files changed, 11 insertions(+)
> 
> diff --git a/bin/ptxdist b/bin/ptxdist
> index 1e10c08d47f2..4a372ff6392c 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -752,6 +752,7 @@ Misc:
>  				it is known by "make"
>    printnext <var>		assumes that the contents of <var> is another
>  				variable and print the contents of this variable
> +  licensecheck			check md5sums of license files for all packages
>    list-packages			print a list of all selected packages
>    local-src <pkg> [<directory>]	overwrite a package source with a locally provided
>  				directory containing the sourcecode.
> @@ -1776,6 +1777,11 @@ EOF
>  			ptxd_make_log "${images[@]}"
>  			exit
>  			;;
> +		licensecheck)
> +			check_premake_compiler &&
> +			ptxd_make_log report
> +			exit
> +			;;
>  		list-packages)
>  			check_config &&
>  			check_deps || return
> diff --git a/doc/ref_parameter.inc b/doc/ref_parameter.inc
> index 74689b9d3cff..aaac8956f147 100644
> --- a/doc/ref_parameter.inc
> +++ b/doc/ref_parameter.inc
> @@ -234,6 +234,9 @@ Misc Actions
>    contents of this variable. Shell variables are currently not checked here.
>    All other rules for ``print`` apply.
>  
> +``licensecheck``
> +  For all selected packages, check the MD5 sums of license files.
> +
>  ``list-packages``
>    print a list of all selected packages. This list does not include the
>    host and cross tools.
> diff --git a/rules/post/ptxd_make_license_report.make b/rules/post/ptxd_make_license_report.make
> index 47dc176668d0..1a13c3ad4964 100644
> --- a/rules/post/ptxd_make_license_report.make
> +++ b/rules/post/ptxd_make_license_report.make
> @@ -15,6 +15,8 @@ PTX_PACKAGES_TARGET := \
>  	$(PTX_PACKAGES_INSTALL) \
>  	$(EXTRA_PACKAGES)
>  
> +report: $(addprefix $(STATEDIR)/,$(addsuffix .report,$(PTX_PACKAGES_SELECTED)))

Hmm, 'report' is a bit too generic for my taste. Just use 'licensecheck'
like the command. Also, You need to add it to PHONY.

mol


> +
>  PHONY += license-report
>  
>  license-report: \
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de