Re: [ptxdist] [PATCH 1/3] libmodbus3: correct license

[Alexander Dahl <post@lespocky.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2080 bytes --]

Hello Bastian,

I sent a patch for the libmodbus3 license issue last year, Message-Id
was <20190510092434.15019-17-ada@thorsis.com> and Michael gave some
feedback, see:

https://www.mail-archive.com/ptxdist@pengutronix.de/msg14488.html

On Wed, May 27, 2020 at 11:04:23PM +0200, Bastian Krause wrote:
> libmodbus reverted its license with v3.0.0, commit 1275387 ("Revert
> libmodbus licence from LGPLv3 to LGPLv2.1") to LGPL-2.1-or-later.
> 820e15f ("SPDX: change LGPL-2.1+ to LGPL-2.1-or-later") updates the SPDX
> identifier in file headers to the recent version.

My initial analysis was this, copied from my old patch:

When introduced to ptxdist back in 2011 with version 3.0.1 libmodbus
was already licensed LGPL-2.1-or-later for the library part and
GPL-3.0-or-later for the tests. This did not change upstream since
then.

Fixes: a8f85be09c663bfad8a34a162b1a63fb3d499985

This is of course better:

Fixes: a8f85be09c66 ("libmodbus3: add new package")

> 
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
>  rules/libmodbus3.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/libmodbus3.make b/rules/libmodbus3.make
> index f206ec4aa..412401cbe 100644
> --- a/rules/libmodbus3.make
> +++ b/rules/libmodbus3.make
> @@ -21,7 +21,7 @@ LIBMODBUS3_SUFFIX	:= tar.gz
>  LIBMODBUS3_URL		:= http://libmodbus.org/site_media/build/$(LIBMODBUS3).$(LIBMODBUS3_SUFFIX)
>  LIBMODBUS3_SOURCE	:= $(SRCDIR)/$(LIBMODBUS3).$(LIBMODBUS3_SUFFIX)
>  LIBMODBUS3_DIR		:= $(BUILDDIR)/$(LIBMODBUS3)
> -LIBMODBUS3_LICENSE	:= LGPL-3.0-only
> +LIBMODBUS3_LICENSE	:= LGPL-2.1-or-later

This is probably not sufficient, see my original patch, and feedback
by Michael on that and by Roland in the other mail.

HTH & Greets
Alex

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de