From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: From: Bastian Krause Date: Fri, 15 May 2020 16:26:29 +0200 Message-Id: <20200515142641.812-4-bst@pengutronix.de> In-Reply-To: <20200515142641.812-1-bst@pengutronix.de> References: <20200515142641.812-1-bst@pengutronix.de> MIME-Version: 1.0 Subject: [ptxdist] [PATCH v2 03/15] ptxd_lib_imx_hab: fix srk fuse file and table generation List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: Bastian Krause srktool's help text states "certificate filenames must be separated by a ',' with no spaces". Line continuating using "\" with the next line being indented leads to a space being inserted between the SRK2 certificate and the SRK3 certificate. srktool does not fail, but ignores everything after the space silently. Thus only the first two certicates end up in the fuse file and table. Fix this by specifying all certs on a single line. Signed-off-by: Bastian Krause --- scripts/lib/ptxd_lib_imx_hab.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/lib/ptxd_lib_imx_hab.sh b/scripts/lib/ptxd_lib_imx_hab.sh index 8be376ff1..034bf82b2 100644 --- a/scripts/lib/ptxd_lib_imx_hab.sh +++ b/scripts/lib/ptxd_lib_imx_hab.sh @@ -43,8 +43,7 @@ ptxd_make_imx_habv4_gen_table_impl() { --table "${table_bin}" \ --efuses "${srk_fuse_bin}" \ --digest sha256 \ - --certs ${tmpdir}/srk1.pem,${tmpdir}/srk2.pem,\ - ${tmpdir}/srk3.pem,${tmpdir}/srk4.pem + --certs ${tmpdir}/srk1.pem,${tmpdir}/srk2.pem,${tmpdir}/srk3.pem,${tmpdir}/srk4.pem } export -f ptxd_make_imx_habv4_gen_table_impl -- 2.26.2 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de