From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]
 helo=dude02.lab.pengutronix.de)
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>) id 1jZVCG-0003hD-5T
 for ptxdist@pengutronix.de; Fri, 15 May 2020 09:55:56 +0200
Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92)
 (envelope-from <mol@pengutronix.de>) id 1jZVCF-0006lk-TV
 for ptxdist@pengutronix.de; Fri, 15 May 2020 09:55:55 +0200
Date: Fri, 15 May 2020 09:55:55 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20200515075555.GD32420@pengutronix.de>
References: <20200514134300.16105-1-bst@pengutronix.de>
 <20200514134300.16105-13-bst@pengutronix.de>
 <476c88b3-fef5-52b5-40f7-86e3be08d588@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <476c88b3-fef5-52b5-40f7-86e3be08d588@pengutronix.de>
Subject: Re: [ptxdist] [PATCH 13/13] code-signing: introduce for ptxconfig,
 add sanity check
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

On Thu, May 14, 2020 at 05:36:54PM +0200, Bastian Krause wrote:
> On 5/14/20 3:43 PM, Bastian Krause wrote:
> > Create a new rules/code-signing.in to be able to select CODE_SIGNING
> > not only in platformconfig but also in ptxconfig.
> > 
> > Also make sure that PTXCONF_CODE_SIGNING_PROVIDER is set correctly if
> > PTXCONF_CODE_SIGNING is set.
> > 
> > Signed-off-by: Bastian Krause <bst@pengutronix.de>
> > ---
> >  rules/code-signing.make | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >  create mode 100644 rules/code-signing.make
> > 
> > diff --git a/rules/code-signing.make b/rules/code-signing.make
> > new file mode 100644
> > index 000000000..db1c5ab88
> > --- /dev/null
> > +++ b/rules/code-signing.make
> > @@ -0,0 +1,13 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2020 by Bastian Krause <bst@pengutronix.de>
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +ifdef PTXCONF_CODE_SIGNING
> > +ifeq ($(call remove_quotes,$(PTXCONF_CODE_SIGNING_PROVIDER)),)
> > +$(error PTXCONF_CODE_SIGNING_PROVIDER must be set correctly)
> > +endif
> > +endif
> > 
> 
> I accidentally dropped:
> 
> diff --git a/rules/code-signing.in b/rules/code-signing.in
> new file mode 100644
> --- /dev/null
> +++ b/rules/code-signing.in
> @@ -0,0 +1,4 @@
> +## SECTION=hosttools_noprompt_ptx
> +
> +config CODE_SIGNING
> +       bool
> 
> Will add it again in v2.

And sort the patch before the rauc changes. It's needed there.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de