From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] host-mfgtools: version bump 1.3.167 -> 1.3.169
Date: Tue, 21 Apr 2020 15:10:43 +0200 [thread overview]
Message-ID: <20200421131043.GK2081@pengutronix.de> (raw)
In-Reply-To: <de141dd6758bb60f6d2512662a77e36a4b756349.camel@diehl.com>
On Tue, Apr 21, 2020 at 12:22:36PM +0000, Denis Osterland-Heim wrote:
> Am Dienstag, den 21.04.2020, 12:54 +0200 schrieb Roland Hieber:
> > On Tue, Apr 21, 2020 at 10:15:01AM +0000, Denis Osterland-Heim wrote:
> > > Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
> > > ---
> > > Hi,
> > >
> > > the 167 source tarball has two toplevel directories, one with the git
> > > submodule content and one without. This was an accident by upstream and
> > > is fixed in 169. It worked on my machine but on older machines (Ubuntu
> > > 16.04) it failed because of mv can not override directories.
> > > I am not sure why it works on my PC.
> >
> > Michael already pushed a fix for this on master in commit
> > e5d4c7c479293eb34345 ("host-mfgtools: fix random extract failures") by
> > handling it in the extract stage. Please rebase onto the current master
> > to test the version bump, and test if the extract step is still needed :)
> Shame on me that I was to slow.
> I will do so. I am sure we can get rid of special extract stage.
>
> I would go with an additional revert patch, or would it be better to squash it?
Just one patch to keep it bisectable.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2020-04-21 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 10:15 Denis Osterland-Heim
2020-04-21 10:54 ` Roland Hieber
2020-04-21 12:22 ` Denis Osterland-Heim
2020-04-21 13:10 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421131043.GK2081@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox