mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/2] tslib: convert to install_tree
Date: Fri, 17 Apr 2020 09:54:09 +0200	[thread overview]
Message-ID: <20200417075409.byziauc5fewnuiv2@pengutronix.de> (raw)
In-Reply-To: <20200417063635.GF2081@pengutronix.de>

On 20-04-17 08:36, Michael Olbrich wrote:
> On Fri, Apr 10, 2020 at 12:35:15PM +0200, Marco Felsch wrote:
> > Convert manual plugin search function to install_tree call to clean up
> > the recipe.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> > Hi Michael,
> > 
> > this patch can be squashed with the 1st if you want.
> > 
> > Regards,
> >   Marco
> > 
> >  rules/tslib.make | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/rules/tslib.make b/rules/tslib.make
> > index 5ee46aa4c..e52e62520 100644
> > --- a/rules/tslib.make
> > +++ b/rules/tslib.make
> > @@ -86,6 +86,7 @@ $(STATEDIR)/tslib.targetinstall:
> >  		/etc/ts.conf)
> >  
> >  	@$(call install_lib, tslib, 0, 0, 0644, libts)
> > +	@$(call install_tree, tslib, 0, 0, 0644, -, /usr/lib/ts)
> 
> 	@$(call install_tree, tslib, 0, 0, 0644, /usr/lib/ts)

Is that possible? According the docs [1] this shouldn't be possible.

[1] https://ptxdist.org/doc/ref_manual.html?highlight=install_tree#install-tree

Regards,
  Marco

> Michael
> 
> >  
> >  ifdef PTXCONF_TSLIB_TS_CALIBRATE
> >  	@$(call install_copy, tslib, 0, 0, 0755, -, /usr/bin/ts_calibrate)
> > @@ -94,10 +95,6 @@ ifdef PTXCONF_TSLIB_TS_TEST
> >  	@$(call install_copy, tslib, 0, 0, 0755, -, /usr/bin/ts_test)
> >  endif
> >  
> > -	@cd $(TSLIB_PKGDIR) && for plugin in `find usr/lib/ts -name "*.so"`; do \
> > -		$(call install_copy, tslib, 0, 0, 0644, -, /$$plugin); \
> > -	done
> > -
> >  	@$(call install_finish, tslib)
> >  
> >  	@$(call touch)
> > -- 
> > 2.20.1

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2020-04-17  7:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 10:35 [ptxdist] [PATCH 1/2] tslib: version bump 1.1 -> 1.21 Marco Felsch
2020-04-10 10:35 ` [ptxdist] [PATCH 2/2] tslib: convert to install_tree Marco Felsch
2020-04-10 10:51   ` Marco Felsch
2020-04-10 11:03     ` Marco Felsch
2020-04-17  6:36   ` Michael Olbrich
2020-04-17  7:54     ` Marco Felsch [this message]
2020-04-17  6:35 ` [ptxdist] [PATCH 1/2] tslib: version bump 1.1 -> 1.21 Michael Olbrich
2020-06-11  9:39 ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417075409.byziauc5fewnuiv2@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox