From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] Networkmanager pppd support broken
Date: Wed, 1 Apr 2020 16:52:40 +0200 [thread overview]
Message-ID: <20200401145240.GA2612@pengutronix.de> (raw)
In-Reply-To: <298e130f917b903797ca31c47abde45aa998fd8b.camel@diehl.com>
On Tue, Mar 31, 2020 at 05:17:04AM +0000, Denis Osterland-Heim wrote:
> Hi Michael,
>
> Am Montag, den 30.03.2020, 21:39 +0200 schrieb Michael Olbrich:
> > On Mon, Mar 30, 2020 at 04:27:48PM +0000, Denis Osterland-Heim wrote:
> > > NetworkManager pppd compile support seems broken.
> > >
> > > ../NetworkManager-1.20.8/src/ppp/nm-pppd-plugin.c:34:10: fatal error: pppd/eui64.h: No such file or directory
> > > 34 | #include <pppd/eui64.h>
> > > | ^~~~~~~~~~~~~~
> > > compilation terminated.
> > >
> > > It seems to refer to https://github.com/wkz/pppd/blob/master/pppd/eui64.h
> > > but this header is not installed to sysroot-target/usr/include/pppd
> > > https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L18
> >
> > It's added here:
> >
> > https://github.com/wkz/pppd/blob/master/pppd/Makefile.linux#L180
> this solves the puzzle.
> eui64.h is only installed if GLOBAL_IPV6 is selected, but NetworkManager pppd
> depends on it unconditionally.
>
> Shall we go with "select" or "depends on" in case of this global setting?
Yes, but add a comment that shows up when it is disabled and the option is
invisible, so that users know what to do.
> >
> > > Does anyone use it?
> >
> > The file is installed and building the NetworkManager pppd support works in
> > my build everything test.
> I should have known this. sorry
:-)
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2020-04-01 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 16:27 Denis Osterland-Heim
2020-03-30 19:39 ` Michael Olbrich
2020-03-31 5:17 ` Denis Osterland-Heim
2020-04-01 14:52 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401145240.GA2612@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox