mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] Python handling was changes in the past, so remove a leftover as well
@ 2020-03-30  7:07 Juergen Borleis
  2020-03-30 12:59 ` Uwe Kleine-König
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Juergen Borleis @ 2020-03-30  7:07 UTC (permalink / raw)
  To: ptxdist

In commit a1a8045112e06d5b15869c60ce4b70056c020666
  "remove hard dependency on Python2"

the handling of the external Python component was changed and a substitution
removed from configure.ac - but the 'Makefile.in' still uses the PYHTON
symbol and creates a strange softlink now. Remove that.

Signed-off-by: Juergen Borleis <jbe@pengutronix.de>

diff --git a/Makefile.in b/Makefile.in
index 31651db..88a32e7 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -65,7 +65,6 @@ environment:
 	@ln -sf @GNU_dirname@ "$(abs_srcdir)/bin/dirname"
 	@ln -sf @GNU_readlink@ "$(abs_srcdir)/bin/readlink"
 	@ln -sf @GNU_sort@ "$(abs_srcdir)/bin/sort"
-	@ln -sf @PYTHON@ "$(abs_srcdir)/bin/python"
 	@ln -sf @SED@ "$(abs_srcdir)/bin/sed"
 	@ln -sf @GNU_xargs@ "$(abs_srcdir)/bin/xargs"
 	@ln -sf @BASH@  "$(abs_srcdir)/bin/bash"

-- 
Pengutronix e.K.                       | Juergen Borleis             |
Steuerwalder Str. 21                   | https://www.pengutronix.de/ |
31137 Hildesheim, Germany              | Phone: +49-5121-206917-5128 |
Amtsgericht Hildesheim, HRA 2686       | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ptxdist] [PATCH] Python handling was changes in the past, so remove a leftover as well
  2020-03-30  7:07 [ptxdist] [PATCH] Python handling was changes in the past, so remove a leftover as well Juergen Borleis
@ 2020-03-30 12:59 ` Uwe Kleine-König
  2020-04-02 15:03 ` [ptxdist] " Michael Olbrich
  2020-04-03 18:52 ` [ptxdist] [APPLIED] " Michael Olbrich
  2 siblings, 0 replies; 9+ messages in thread
From: Uwe Kleine-König @ 2020-03-30 12:59 UTC (permalink / raw)
  To: ptxdist, jbe

Hi Jürgen,

$Subject ~= s/changes/changed/

On Mon, Mar 30, 2020 at 09:07:01AM +0200, Juergen Borleis wrote:
> In commit a1a8045112e06d5b15869c60ce4b70056c020666
>   "remove hard dependency on Python2"
> 
> the handling of the external Python component was changed and a substitution
> removed from configure.ac - but the 'Makefile.in' still uses the PYHTON

s/PYHTON/PYTHON/

Liebe Grüße
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ptxdist] Python handling was changes in the past, so remove a leftover as well
  2020-03-30  7:07 [ptxdist] [PATCH] Python handling was changes in the past, so remove a leftover as well Juergen Borleis
  2020-03-30 12:59 ` Uwe Kleine-König
@ 2020-04-02 15:03 ` Michael Olbrich
  2020-04-03 17:21   ` Uwe Kleine-König
  2020-04-03 18:52 ` [ptxdist] [APPLIED] " Michael Olbrich
  2 siblings, 1 reply; 9+ messages in thread
From: Michael Olbrich @ 2020-04-02 15:03 UTC (permalink / raw)
  To: ptxdist

Thanks, applied as 70e95734668542ac638d5cb8a759ad402d678ff4.

Michael

[sent from post-receive hook]

On Thu, 02 Apr 2020 17:03:29 +0200, Juergen Borleis <jbe@pengutronix.de> wrote:
> In commit a1a8045112e06d5b15869c60ce4b70056c020666
>   "remove hard dependency on Python2"
> 
> the handling of the external Python component was changed and a substitution
> removed from configure.ac - but the 'Makefile.in' still uses the PYHTON
> symbol and creates a strange softlink now. Remove that.
> 
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> 
> diff --git a/Makefile.in b/Makefile.in
> index 31651db..88a32e7 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -65,7 +65,6 @@ environment:
>  	@ln -sf @GNU_dirname@ "$(abs_srcdir)/bin/dirname"
>  	@ln -sf @GNU_readlink@ "$(abs_srcdir)/bin/readlink"
>  	@ln -sf @GNU_sort@ "$(abs_srcdir)/bin/sort"
> -	@ln -sf @PYTHON@ "$(abs_srcdir)/bin/python"
>  	@ln -sf @SED@ "$(abs_srcdir)/bin/sed"
>  	@ln -sf @GNU_xargs@ "$(abs_srcdir)/bin/xargs"
>  	@ln -sf @BASH@  "$(abs_srcdir)/bin/bash"
> 

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ptxdist] Python handling was changes in the past, so remove a leftover as well
  2020-04-02 15:03 ` [ptxdist] " Michael Olbrich
@ 2020-04-03 17:21   ` Uwe Kleine-König
  2020-04-03 18:36     ` Michael Olbrich
  0 siblings, 1 reply; 9+ messages in thread
From: Uwe Kleine-König @ 2020-04-03 17:21 UTC (permalink / raw)
  To: ptxdist

On Thu, Apr 02, 2020 at 05:03:29PM +0200, Michael Olbrich wrote:
> Thanks, applied as 70e95734668542ac638d5cb8a759ad402d678ff4.

Sad that the two typos I indicated were not fixed :-|

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ptxdist] Python handling was changes in the past, so remove a leftover as well
  2020-04-03 17:21   ` Uwe Kleine-König
@ 2020-04-03 18:36     ` Michael Olbrich
  0 siblings, 0 replies; 9+ messages in thread
From: Michael Olbrich @ 2020-04-03 18:36 UTC (permalink / raw)
  To: ptxdist

On Fri, Apr 03, 2020 at 07:21:08PM +0200, Uwe Kleine-König wrote:
> On Thu, Apr 02, 2020 at 05:03:29PM +0200, Michael Olbrich wrote:
> > Thanks, applied as 70e95734668542ac638d5cb8a759ad402d678ff4.
> 
> Sad that the two typos I indicated were not fixed :-|

Actually I fixed one of them, but lost the other somehow :-/.

Right now, I'm quoting the original message. I should probably replace that
with the actual commit that was merged.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ptxdist] [APPLIED] Python handling was changes in the past, so remove a leftover as well
  2020-03-30  7:07 [ptxdist] [PATCH] Python handling was changes in the past, so remove a leftover as well Juergen Borleis
  2020-03-30 12:59 ` Uwe Kleine-König
  2020-04-02 15:03 ` [ptxdist] " Michael Olbrich
@ 2020-04-03 18:52 ` Michael Olbrich
  2020-04-03 18:53   ` Michael Olbrich
  2 siblings, 1 reply; 9+ messages in thread
From: Michael Olbrich @ 2020-04-03 18:52 UTC (permalink / raw)
  To: ptxdist

Thanks, applied as 70e95734668542ac638d5cb8a759ad402d678ff4.

Michael

[sent from post-receive hook]

On Fri, 03 Apr 2020 20:52:04 +0200, Juergen Borleis <jbe@pengutronix.de> wrote:
> In commit a1a8045112e06d5b15869c60ce4b70056c020666
>   "remove hard dependency on Python2"
> 
> the handling of the external Python component was changed and a substitution
> removed from configure.ac - but the 'Makefile.in' still uses the PYTHON
> symbol and creates a strange softlink now. Remove that.
> 
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> 
> Message-Id: <202003300907.01952.jbe@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/Makefile.in b/Makefile.in
> index 31651dbbd8c3..88a32e7cfc36 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -65,7 +65,6 @@ environment:
>  	@ln -sf @GNU_dirname@ "$(abs_srcdir)/bin/dirname"
>  	@ln -sf @GNU_readlink@ "$(abs_srcdir)/bin/readlink"
>  	@ln -sf @GNU_sort@ "$(abs_srcdir)/bin/sort"
> -	@ln -sf @PYTHON@ "$(abs_srcdir)/bin/python"
>  	@ln -sf @SED@ "$(abs_srcdir)/bin/sed"
>  	@ln -sf @GNU_xargs@ "$(abs_srcdir)/bin/xargs"
>  	@ln -sf @BASH@  "$(abs_srcdir)/bin/bash"

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ptxdist] [APPLIED] Python handling was changes in the past, so remove a leftover as well
  2020-04-03 18:52 ` [ptxdist] [APPLIED] " Michael Olbrich
@ 2020-04-03 18:53   ` Michael Olbrich
  2020-04-03 20:43     ` Uwe Kleine-König
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Olbrich @ 2020-04-03 18:53 UTC (permalink / raw)
  To: ptxdist

So maybe like this.

On Fri, Apr 03, 2020 at 08:52:04PM +0200, Michael Olbrich wrote:
> Thanks, applied as 70e95734668542ac638d5cb8a759ad402d678ff4.
> 
> Michael
> 
> [sent from post-receive hook]
> 
> On Fri, 03 Apr 2020 20:52:04 +0200, Juergen Borleis <jbe@pengutronix.de> wrote:
> > In commit a1a8045112e06d5b15869c60ce4b70056c020666
> >   "remove hard dependency on Python2"
> > 
> > the handling of the external Python component was changed and a substitution
> > removed from configure.ac - but the 'Makefile.in' still uses the PYTHON

PYTHON is fixed here.

> > symbol and creates a strange softlink now. Remove that.
> > 
> > Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> > 
> > Message-Id: <202003300907.01952.jbe@pengutronix.de>
> > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>

And the extra tags are there as well.

Michael

> > 
> > diff --git a/Makefile.in b/Makefile.in
> > index 31651dbbd8c3..88a32e7cfc36 100644
> > --- a/Makefile.in
> > +++ b/Makefile.in
> > @@ -65,7 +65,6 @@ environment:
> >  	@ln -sf @GNU_dirname@ "$(abs_srcdir)/bin/dirname"
> >  	@ln -sf @GNU_readlink@ "$(abs_srcdir)/bin/readlink"
> >  	@ln -sf @GNU_sort@ "$(abs_srcdir)/bin/sort"
> > -	@ln -sf @PYTHON@ "$(abs_srcdir)/bin/python"
> >  	@ln -sf @SED@ "$(abs_srcdir)/bin/sed"
> >  	@ln -sf @GNU_xargs@ "$(abs_srcdir)/bin/xargs"
> >  	@ln -sf @BASH@  "$(abs_srcdir)/bin/bash"
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ptxdist] [APPLIED] Python handling was changes in the past, so remove a leftover as well
  2020-04-03 18:53   ` Michael Olbrich
@ 2020-04-03 20:43     ` Uwe Kleine-König
  2020-04-04  5:13       ` Michael Olbrich
  0 siblings, 1 reply; 9+ messages in thread
From: Uwe Kleine-König @ 2020-04-03 20:43 UTC (permalink / raw)
  To: ptxdist

Hallo Michael,

On Fri, Apr 03, 2020 at 08:53:52PM +0200, Michael Olbrich wrote:
> So maybe like this.
> 
> On Fri, Apr 03, 2020 at 08:52:04PM +0200, Michael Olbrich wrote:
> > Thanks, applied as 70e95734668542ac638d5cb8a759ad402d678ff4.
> > 
> > Michael
> > 
> > [sent from post-receive hook]
> > 
> > On Fri, 03 Apr 2020 20:52:04 +0200, Juergen Borleis <jbe@pengutronix.de> wrote:
> > > In commit a1a8045112e06d5b15869c60ce4b70056c020666
> > >   "remove hard dependency on Python2"
> > > 
> > > the handling of the external Python component was changed and a substitution
> > > removed from configure.ac - but the 'Makefile.in' still uses the PYTHON
> 
> PYTHON is fixed here.
> 
> > > symbol and creates a strange softlink now. Remove that.
> > > 
> > > Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> > > 
> > > Message-Id: <202003300907.01952.jbe@pengutronix.de>
> > > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> And the extra tags are there as well.

While improving here: The empty line between Jürgen's S-o-b and the
Message-Id could be dropped.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ptxdist] [APPLIED] Python handling was changes in the past, so remove a leftover as well
  2020-04-03 20:43     ` Uwe Kleine-König
@ 2020-04-04  5:13       ` Michael Olbrich
  0 siblings, 0 replies; 9+ messages in thread
From: Michael Olbrich @ 2020-04-04  5:13 UTC (permalink / raw)
  To: ptxdist

On Fri, Apr 03, 2020 at 10:43:18PM +0200, Uwe Kleine-König wrote:
> On Fri, Apr 03, 2020 at 08:53:52PM +0200, Michael Olbrich wrote:
> > So maybe like this.
> > 
> > On Fri, Apr 03, 2020 at 08:52:04PM +0200, Michael Olbrich wrote:
> > > Thanks, applied as 70e95734668542ac638d5cb8a759ad402d678ff4.
> > > 
> > > Michael
> > > 
> > > [sent from post-receive hook]
> > > 
> > > On Fri, 03 Apr 2020 20:52:04 +0200, Juergen Borleis <jbe@pengutronix.de> wrote:
> > > > In commit a1a8045112e06d5b15869c60ce4b70056c020666
> > > >   "remove hard dependency on Python2"
> > > > 
> > > > the handling of the external Python component was changed and a substitution
> > > > removed from configure.ac - but the 'Makefile.in' still uses the PYTHON
> > 
> > PYTHON is fixed here.
> > 
> > > > symbol and creates a strange softlink now. Remove that.
> > > > 
> > > > Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> > > > 
> > > > Message-Id: <202003300907.01952.jbe@pengutronix.de>
> > > > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > 
> > And the extra tags are there as well.
> 
> While improving here: The empty line between Jürgen's S-o-b and the
> Message-Id could be dropped.

I know. I have no idea how it got there. No other commit has it and the
tags are applied by git-am. Maybe I accidentally added it while editing the
commit message.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-04-04  5:13 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30  7:07 [ptxdist] [PATCH] Python handling was changes in the past, so remove a leftover as well Juergen Borleis
2020-03-30 12:59 ` Uwe Kleine-König
2020-04-02 15:03 ` [ptxdist] " Michael Olbrich
2020-04-03 17:21   ` Uwe Kleine-König
2020-04-03 18:36     ` Michael Olbrich
2020-04-03 18:52 ` [ptxdist] [APPLIED] " Michael Olbrich
2020-04-03 18:53   ` Michael Olbrich
2020-04-03 20:43     ` Uwe Kleine-König
2020-04-04  5:13       ` Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox