mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Alexander Dahl <post@lespocky.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] u-boot: Fix typos in cfghash calls
Date: Fri, 27 Mar 2020 14:21:02 +0100	[thread overview]
Message-ID: <20200327132101.mz7t3okrnilf5okl@falbala.internal.home.lespocky.de> (raw)
In-Reply-To: <20200327123634.GB5618@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 1394 bytes --]

Hei hei,

On Fri, Mar 27, 2020 at 01:36:34PM +0100, Michael Olbrich wrote:
> On Fri, Mar 27, 2020 at 08:08:31AM +0100, Alexander Dahl wrote:
> > Fixes: 189159b2c34b ("u-boot: use ptx/cfghash-file instead of manual tricks to rebuild the package")
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > ---
> >  rules/u-boot.make | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/rules/u-boot.make b/rules/u-boot.make
> > index 66f40cad6..7454e9a0c 100644
> > --- a/rules/u-boot.make
> > +++ b/rules/u-boot.make
> > @@ -40,13 +40,13 @@ ifdef PTXCONF_U_BOOT_BOOT_SCRIPT
> >  U_BOOT_BOOT_SCRIPT_TXT := $(call ptx/in-platformconfigdir, uboot.scr)
> >  U_BOOT_BOOT_SCRIPT_BIN := $(call remove_quotes, \
> >  	$(PTXCONF_U_BOOT_BOOT_SCRIPT_ROOTFS_PATH))
> > -$(call ptx/cfghash-file, OS_RELEU_BOOT, $(U_BOOT_BOOT_SCRIPT_TXT))
> > +$(call ptx/cfghash-file, U_BOOT, $(U_BOOT_BOOT_SCRIPT_TXT))
> 
> Ugh, right. I should have tested this a bit more.
> 
> Thanks for catching this.

FWIW, I also did not build test this … O:-)

Have a nice weekend.
Alex

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 92 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2020-03-27 13:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  7:08 Alexander Dahl
2020-03-27 12:36 ` Michael Olbrich
2020-03-27 13:21   ` Alexander Dahl [this message]
2020-04-01 15:06 ` [ptxdist] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200327132101.mz7t3okrnilf5okl@falbala.internal.home.lespocky.de \
    --to=post@lespocky.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox