Re: [ptxdist] [PATCH 3/3] rootfs: issue: Make date string reproducible

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Mar 20, 2020 at 01:08:41PM +0100, Alexander Dahl wrote:
> Am Freitag, 20. März 2020, 12:39:33 CET schrieb Michael Olbrich:
> > On Thu, Feb 27, 2020 at 03:44:49PM +0100, Alexander Dahl wrote:
> > > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > 
> > Maybe use the same value as os-release?
> 
> Would make sense, I thought that's what 
> 
> $(shell date --utc --date @$(SOURCE_DATE_EPOCH) '+%FT%T%z')
> 
> would yield, given SOURCE_DATE_EPOCH is always set? I used that line in both 
> patches. 
> 
> I'm sorry, I don't understand what you mean here, or what you mean with that 
> question above.

I mean that the discussion we had about the timestamp for os-release is
applies to this packages as well and they should probably share the
resulting timestamp. Maybe add the options to rules/project-name.in and use
the resulting value for both packages.

The packages should be rebuilt when this changes, but I'm working on some
infrastructure to simplify this, so don't worry about this, I'll handle it.

Michael

> > > ---
> > > 
> > >  rules/rootfs.make | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/rules/rootfs.make b/rules/rootfs.make
> > > index b33805d77..6a89bfcc4 100644
> > > --- a/rules/rootfs.make
> > > +++ b/rules/rootfs.make
> > > @@ -210,7 +210,7 @@ ifdef PTXCONF_ROOTFS_ISSUE
> > > 
> > >  	@$(call install_replace, rootfs, /etc/issue, \
> > >  	
> > >  		@EXTRAVERSION@, $(PTXDIST_VERSION_SCM))
> > >  	
> > >  	@$(call install_replace, rootfs, /etc/issue, \
> > > 
> > > -		@DATE@, $(shell date +%FT%T%z))
> > > +		@DATE@, $(shell date --utc --date @$(SOURCE_DATE_EPOCH) '+%FT%T%z'))
> > > 
> > >  	@$(call install_replace, rootfs, /etc/issue, \
> > >  	
> > >  		@VENDOR@, $(PTXCONF_PROJECT_VENDOR))
> > >  	
> > >  	@$(call install_replace, rootfs, /etc/issue, \
> 
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de