From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [PATCH 2/3] os-release: Make date string reproducible
Date: Fri, 20 Mar 2020 12:38:13 +0100 [thread overview]
Message-ID: <20200320113813.GB7533@pengutronix.de> (raw)
In-Reply-To: <20200229174127.rprrfmjnlkukpxt2@falbala.internal.home.lespocky.de>
Hi,
On Sat, Feb 29, 2020 at 06:41:27PM +0100, Alexander Dahl wrote:
> On Sat, Feb 29, 2020 at 09:48:28AM +0100, Michael Olbrich wrote:
> > On Fri, Feb 28, 2020 at 05:14:41PM +0100, Alexander Dahl wrote:
> > > On Fri, Feb 28, 2020 at 04:40:10PM +0100, Roland Hieber wrote:
> > > > Instead we could use the date of ./tarball-version (like
> > > > PTXDIST_BSP_AUTOVERSION does too) or the current VCS commit; or if the
> > > > BSP is not a VCS repo, or if the worktree has local changes, fall back
> > > > to searching for the most recent file in the current BSP.
> > >
> > > Or the user could just do anything she wants and feed it into
> > > REPRODUCIBLE_TIMESTAMP_CUSTOM?
> >
> > How about
> > - 'now' (what we have now)
>
> Nice for backwards compatibility and to not break expections of users.
>
> > - 'last commit' (CommitDate fromt the last commit)
>
> Assuming the BSP is in Git, but most users will do that anyway.
>
> I consider this a good one. You get a comprehensible timestamp related
> to the BSP (instead of the ptxdist or toolchain version) while still
> getting the same result on multiple builds of the same revision of the
> BSP, wouldn't you?
Yes, exactly. And it should be the CommitDate not the AuthorDate.
It will be reproducible but still show when the last changes happened.
> > - 'custom' (from a string)
> >
> > I'm not sure what you'd want to put in a custom string, but I wouldn't mind
> > adding it.
>
> +1
I'm sure someone will find a use-case for this as well...
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2020-03-20 11:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:44 [ptxdist] [PATCH 0/3] Minor build improvements Alexander Dahl
2020-02-27 14:44 ` [ptxdist] [PATCH 1/3] opkg: Regenerate config after input variable changes Alexander Dahl
2020-03-20 11:31 ` Michael Olbrich
2020-03-27 13:24 ` Michael Olbrich
2020-02-27 14:44 ` [ptxdist] [PATCH 2/3] os-release: Make date string reproducible Alexander Dahl
2020-02-28 10:16 ` Roland Hieber
2020-02-28 15:40 ` Roland Hieber
2020-02-28 16:14 ` Alexander Dahl
2020-02-29 8:48 ` Michael Olbrich
2020-02-29 17:41 ` Alexander Dahl
2020-03-20 11:38 ` Michael Olbrich [this message]
2020-02-27 14:44 ` [ptxdist] [PATCH 3/3] rootfs: issue: " Alexander Dahl
2020-03-20 11:39 ` Michael Olbrich
2020-03-20 12:08 ` Alexander Dahl
2020-03-20 12:44 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320113813.GB7533@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ada@thorsis.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox