Re: [ptxdist] [PATCH 06/34] dropbear: Add license information

[Roland Hieber <rhi@pengutronix.de>]

On Tue, Mar 10, 2020 at 03:23:30PM +0100, Alexander Dahl wrote:
> Hello Roland,
> 
> Am Mittwoch, 29. Mai 2019, 11:31:55 CET schrieb Roland Hieber:
> > On Wed, May 29, 2019 at 10:00:00AM +0200, Alexander Dahl wrote:
> > > Am Mittwoch, 29. Mai 2019, 09:49:23 CEST schrieb Michael Olbrich:
> > > > On Fri, May 10, 2019 at 11:24:06AM +0200, Alexander Dahl wrote:
> > > > > The parts written for dropbear itself are MIT licensed, as are those
> > > > > imported from PuTTY. Some parts come from OpenSSH with BSD 2 clause,
> > > > > some parts are in the public domain. curve25519 parts from Google are
> > > > > BSD 3 clause licensed. Everything is explained in the file 'LICENSE'.
> > > > > 
> > > > > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > > > > ---
> > > > > 
> > > > >  rules/dropbear.make | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > > 
> > > > > diff --git a/rules/dropbear.make b/rules/dropbear.make
> > > > > index c1ad614ef..016c4d713 100644
> > > > > --- a/rules/dropbear.make
> > > > > +++ b/rules/dropbear.make
> > > > > @@ -25,6 +25,8 @@ DROPBEAR_SUFFIX		:= tar.bz2
> > > > > 
> > > > >  DROPBEAR_URL		:=
> > > > >  http://matt.ucc.asn.au/dropbear/releases/$(DROPBEAR).$(DROPBEAR_SUFFI
> > > > >  X)
> > > > >  DROPBEAR_SOURCE		:= $(SRCDIR)/$(DROPBEAR).$(DROPBEAR_SUFFIX)
> > > > >  DROPBEAR_DIR		:= $(BUILDDIR)/$(DROPBEAR)
> > > > > 
> > > > > +DROPBEAR_LICENSE	:= MIT AND BSD-2-Clause AND BSD-3-Clause
> > > > > +DROPBEAR_LICENSE_FILES	:=
> > > > > file://LICENSE;md5=a5ec40cafba26fc4396d0b550f824e01
> > > > 
> > > > The license text for BSD-2-Clause is missing.
> > > 
> > > It is not in the file LICENSE, but as stated in that file applies to
> > > loginrec.c, loginrec.h, atomicio.h, and atomicio.c. Each of those files
> > > contains the license text. Just pick one and add it to
> > > DROPBEAR_LICENSE_FILES?
> > Oh, and sshpty.[ch] includes a license which I couldn't find in the SPDX
> > repo:
> > 
> >      * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
> >      *                    All rights reserved
> >      *
> >      * As far as I am concerned, the code I have written for this software
> >      * can be used freely for any purpose.  Any derived versions of this
> >      * software must be clearly marked as such, and if the derived work is
> >      * incompatible with the protocol description in the RFC file, it must
> > be * called by a name other than "ssh" or "Secure Shell".
> > 
> > So I would add an "AND unknown" here too, until my license request [0] is
> > approved :)
> > 
> > [0]: http://13.57.134.254/app/license_requests/39/
> 
> What's the state on this one? Any updates? Or should I just add your "ADD 
> unknown"?

Ah right – the GitHub issue [2] didn't trigger a reminder to answer to
this mail :) It got approved as "SSH-short", so no need for "unknown".

[2]: https://github.com/spdx/license-list-XML/pull/936

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de