From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.kundenserver.de ([212.227.126.130]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j867Q-0005x3-Ld for ptxdist@pengutronix.de; Sat, 29 Feb 2020 18:41:41 +0100 Date: Sat, 29 Feb 2020 18:41:27 +0100 From: Alexander Dahl Message-ID: <20200229174127.rprrfmjnlkukpxt2@falbala.internal.home.lespocky.de> References: <20200227144449.29660-1-ada@thorsis.com> <20200227144449.29660-3-ada@thorsis.com> <20200228101609.hq5ubu5zqi6xfklx@pengutronix.de> <20200228154010.t3qdmkrtcojxyf6w@pengutronix.de> <20200228161441.ndqubgbnf4mi4vza@falbala.internal.home.lespocky.de> <20200229084828.GI3627@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20200229084828.GI3627@pengutronix.de> Subject: Re: [ptxdist] [PATCH 2/3] os-release: Make date string reproducible List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0351188546==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: Alexander Dahl --===============0351188546== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rd5qtqhzutf4jnkt" Content-Disposition: inline --rd5qtqhzutf4jnkt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Sat, Feb 29, 2020 at 09:48:28AM +0100, Michael Olbrich wrote: > On Fri, Feb 28, 2020 at 05:14:41PM +0100, Alexander Dahl wrote: > > On Fri, Feb 28, 2020 at 04:40:10PM +0100, Roland Hieber wrote: > > > Instead we could use the date of ./tarball-version (like > > > PTXDIST_BSP_AUTOVERSION does too) or the current VCS commit; or if the > > > BSP is not a VCS repo, or if the worktree has local changes, fall back > > > to searching for the most recent file in the current BSP. > >=20 > > Or the user could just do anything she wants and feed it into > > REPRODUCIBLE_TIMESTAMP_CUSTOM? >=20 > How about > - 'now' (what we have now) Nice for backwards compatibility and to not break expections of users. > - 'last commit' (CommitDate fromt the last commit) Assuming the BSP is in Git, but most users will do that anyway.=20 I consider this a good one. You get a comprehensible timestamp related to the BSP (instead of the ptxdist or toolchain version) while still getting the same result on multiple builds of the same revision of the BSP, wouldn't you? > - 'custom' (from a string) >=20 > I'm not sure what you'd want to put in a custom string, but I wouldn't mi= nd > adding it. +1 Greets Alex --=20 /"\ ASCII RIBBON | =BBWith the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.=AB / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie) --rd5qtqhzutf4jnkt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEwo7muQJjlc+Prwj6NK3NAHIhXMYFAl5aokMACgkQNK3NAHIh XMZIOhAAuKKWapLIFdlS43q/CaU+GczgZ/fklvhujJJPHIOxZPSQJnwvTtBsQIbE rOpJ4Dc6UnnUk7E2uFBnQi63zU76A5FQx0dQQlLrUw9S8Kn94v5eVzeNNZvCkyts 3rV0PuBuKg9yEUXnMDqj9pJLhMLWgunsyjkbATTtBZJO/TLXVG2ygdmpeBGP/pF9 OZvnnyEE7r+X7fm6vE36vZc5d2xUh5Ot01+1umG6WsfeV5JMRSctfbfkS/q+Fby3 9dnAHHZkFq1V4/0h6U0NSdI+z4gmBGWj+94Zghs5dnyHKzGYZy97lLATBzkGXFBV ZWgiOTPpuRCXE2BkwVrh6CqVLTYNEqx89lUYCOomd/SSQqm3W8FZVmO2E5ADpC+e dtfFLdGKI4Pe2OrPAP7DXfxsTfWoepGJeaZAte4erS1FcODwIMoTtLP/mJkd/bno xVGPyjIR70LG6zUtRwfZJPr7RLa4bFJ61vx++n5+knpxmzOOOQDqu2YDt9B9fJ8T 3Ef5ezZU8hcprqoYH3hk4UTMD1rWqqMqjMNxI6fzuFxac2ixn3tYwsNUq5RmePIE NGDuJgAUtYQQepCSLgR05U0M6eya/s6mE/fUEnxyi6YMerH36DJt8rBU8/s2K4oF 3r16MKrPQlZk6Vrq8aY4jo8oBq+vJ/I3tUm1bzf8u4d0FsqksHM= =agBy -----END PGP SIGNATURE----- --rd5qtqhzutf4jnkt-- --===============0351188546== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de --===============0351188546==--