Re: [ptxdist] [PATCH 2/3] os-release: Make date string reproducible

[Alexander Dahl <post@lespocky.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1525 bytes --]

Hello,

On Sat, Feb 29, 2020 at 09:48:28AM +0100, Michael Olbrich wrote:
> On Fri, Feb 28, 2020 at 05:14:41PM +0100, Alexander Dahl wrote:
> > On Fri, Feb 28, 2020 at 04:40:10PM +0100, Roland Hieber wrote:
> > > Instead we could use the date of ./tarball-version (like
> > > PTXDIST_BSP_AUTOVERSION does too) or the current VCS commit; or if the
> > > BSP is not a VCS repo, or if the worktree has local changes, fall back
> > > to searching for the most recent file in the current BSP.
> > 
> > Or the user could just do anything she wants and feed it into
> > REPRODUCIBLE_TIMESTAMP_CUSTOM?
> 
> How about
>  - 'now' (what we have now)

Nice for backwards compatibility and to not break expections of users.

>  - 'last commit' (CommitDate fromt the last commit)

Assuming the BSP is in Git, but most users will do that anyway. 

I consider this a good one. You get a comprehensible timestamp related
to the BSP (instead of the ptxdist or toolchain version) while still
getting the same result on multiple builds of the same revision of the
BSP, wouldn't you?

>  - 'custom' (from a string)
> 
> I'm not sure what you'd want to put in a custom string, but I wouldn't mind
> adding it.

+1

Greets
Alex

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 92 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de